Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2409923002: cc: Rename SwapBuffers on CompositorFrameSink to SubmitCompositorFrame (Closed)

Created:
4 years, 2 months ago by danakj
Modified:
4 years, 2 months ago
CC:
anandc+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, blink-reviews, cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, dtrainor+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, jam, jbauman+watch_chromium.org, jessicag+watch-blimp_chromium.org, kalyank, khushalsagar+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, kylechar, lethalantidote+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, mlamouri+watch-content_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, piman+watch_chromium.org, rjkroege, scf+watch-blimp_chromium.org, scheduler-bugs_chromium.org, shaktisahu+watch-blimp_chromium.org, sievers+watch_chromium.org, sriramsr+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, Ian Vollick
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Rename SwapBuffers on CompositorFrameSink to SubmitCompositorFrame This renames everything to do with "Swap" in the layer/delegating compositors to be "Submit" instead, including inside LayerTreeHost and the Scheduler. CompositorFrameSink::SwapBuffers -> SubmitCompositorFrame CompositorFrameSinkClient::DidSwapBuffersComplete -> DidReceiveCompositorFrameAck LayerTreeHost::DidCompleteSwapBuffers -> DidReceiveCompositorFrameAck ScheduledActionDrawAndSwap -> ScheduledActionSubmitCompositorFrame SwapThrottled -> SubmitThrottled R=enne@chromium.org, khushalsagar@chromium.org, sunnyps@chromium.org, sky@chromium.org, boliu@chromium.org BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/9d124421c3113ae9e87d92570a0d187a72d4154a Cr-Commit-Position: refs/heads/master@{#425245}

Patch Set 1 : swap-to-submit: . #

Patch Set 2 : swap-to-submit: rebase #

Total comments: 16

Patch Set 3 : swap-to-submit: rebase #

Patch Set 4 : swap-to-submit: . #

Total comments: 4

Patch Set 5 : swap-to-submit: nits #

Patch Set 6 : swap-to-submit: rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+621 lines, -649 lines) Patch
M blimp/client/app/compositor/browser_compositor.h View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/app/compositor/browser_compositor.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/core/compositor/blimp_compositor.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M blimp/client/core/compositor/blimp_compositor.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M blimp/client/core/compositor/blimp_compositor_frame_sink.h View 1 chunk +2 lines, -2 lines 0 comments Download
M blimp/client/core/compositor/blimp_compositor_frame_sink.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M blimp/client/core/compositor/blimp_compositor_frame_sink_proxy.h View 2 chunks +3 lines, -3 lines 0 comments Download
M blimp/client/core/compositor/blimp_compositor_frame_sink_unittest.cc View 6 chunks +23 lines, -23 lines 0 comments Download
M blimp/client/support/compositor/blimp_embedder_compositor.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/blimp/layer_tree_host_remote.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/blimp/layer_tree_host_remote.cc View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M cc/blimp/layer_tree_host_remote_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M cc/output/compositor_frame_sink.h View 1 chunk +4 lines, -4 lines 0 comments Download
M cc/output/compositor_frame_sink.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M cc/output/compositor_frame_sink_client.h View 1 2 3 1 chunk +27 lines, -22 lines 0 comments Download
M cc/output/compositor_frame_sink_unittest.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M cc/scheduler/compositor_timing_history.h View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/scheduler/compositor_timing_history.cc View 9 chunks +32 lines, -32 lines 0 comments Download
M cc/scheduler/scheduler.h View 1 2 3 3 chunks +10 lines, -6 lines 0 comments Download
M cc/scheduler/scheduler.cc View 1 2 3 4 chunks +19 lines, -19 lines 0 comments Download
M cc/scheduler/scheduler_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/scheduler/scheduler_settings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.h View 1 2 3 7 chunks +17 lines, -20 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 1 2 3 4 22 chunks +59 lines, -58 lines 0 comments Download
M cc/scheduler/scheduler_state_machine_unittest.cc View 1 2 3 42 chunks +95 lines, -121 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 1 2 3 72 chunks +139 lines, -142 lines 0 comments Download
M cc/surfaces/direct_compositor_frame_sink.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/direct_compositor_frame_sink.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/surfaces/direct_compositor_frame_sink_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_channel_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_compositor_frame_sink.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/fake_compositor_frame_sink.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M cc/test/fake_compositor_frame_sink_client.h View 3 chunks +5 lines, -8 lines 0 comments Download
M cc/test/fake_compositor_frame_sink_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/test/fake_layer_tree_host_impl_client.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/layer_tree_host_remote_for_testing.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/test/layer_tree_host_remote_for_testing.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/test/scheduler_test_common.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M cc/test/stub_layer_tree_host_client.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/stub_layer_tree_host_single_thread_client.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/test_compositor_frame_sink.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/test/test_compositor_frame_sink.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/test/test_hooks.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/channel_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_client.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 2 3 chunks +6 lines, -9 lines 0 comments Download
M cc/trees/layer_tree_host_in_process.h View 1 chunk +3 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_single_thread_client.h View 1 chunk +3 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_remote_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/proxy_impl.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M cc/trees/proxy_impl.cc View 1 2 3 4 chunks +16 lines, -16 lines 0 comments Download
M cc/trees/proxy_main.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/proxy_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/remote_channel_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/remote_channel_impl.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M cc/trees/remote_channel_main.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/remote_channel_main.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 2 3 3 chunks +8 lines, -7 lines 0 comments Download
M cc/trees/threaded_channel.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/threaded_channel.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/android/synchronous_compositor_frame_sink.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/android/synchronous_compositor_frame_sink.cc View 5 chunks +12 lines, -10 lines 0 comments Download
M content/renderer/android/synchronous_compositor_proxy.h View 2 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/android/synchronous_compositor_proxy.cc View 5 chunks +10 lines, -8 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/renderer_compositor_frame_sink.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/renderer_compositor_frame_sink.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M services/ui/public/cpp/compositor_frame_sink.h View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M services/ui/public/cpp/compositor_frame_sink.cc View 1 2 3 2 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/compositor.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/compositor.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 41 (26 generated)
danakj
enne: overall sunnyps: cc/scheduler/ boliu: c/b/ and c/r/android/ khushal: blimp/ sky: services/
4 years, 2 months ago (2016-10-11 01:00:26 UTC) #8
sky
LGTM - question I raised below can be resolved separately. https://codereview.chromium.org/2409923002/diff/60001/services/ui/public/cpp/compositor_frame_sink.cc File services/ui/public/cpp/compositor_frame_sink.cc (right): https://codereview.chromium.org/2409923002/diff/60001/services/ui/public/cpp/compositor_frame_sink.cc#newcode57 ...
4 years, 2 months ago (2016-10-11 02:43:25 UTC) #19
boliu
lgtm
4 years, 2 months ago (2016-10-11 15:16:33 UTC) #20
Khushal
lgtm
4 years, 2 months ago (2016-10-11 17:18:45 UTC) #21
enne (OOO)
lgtm https://codereview.chromium.org/2409923002/diff/60001/cc/output/compositor_frame_sink_client.h File cc/output/compositor_frame_sink_client.h (right): https://codereview.chromium.org/2409923002/diff/60001/cc/output/compositor_frame_sink_client.h#newcode48 cc/output/compositor_frame_sink_client.h:48: // The CompositorFrameSink is lost when the ContextProviders ...
4 years, 2 months ago (2016-10-11 17:26:00 UTC) #22
sunnyps
https://codereview.chromium.org/2409923002/diff/60001/cc/output/compositor_frame_sink.h File cc/output/compositor_frame_sink.h (right): https://codereview.chromium.org/2409923002/diff/60001/cc/output/compositor_frame_sink.h#newcode108 cc/output/compositor_frame_sink.h:108: // DidReceiveCompositorFrameAck() asynchronously when the frame has been bikeshed: ...
4 years, 2 months ago (2016-10-11 18:32:49 UTC) #23
danakj
https://codereview.chromium.org/2409923002/diff/60001/services/ui/public/cpp/compositor_frame_sink.cc File services/ui/public/cpp/compositor_frame_sink.cc (right): https://codereview.chromium.org/2409923002/diff/60001/services/ui/public/cpp/compositor_frame_sink.cc#newcode57 services/ui/public/cpp/compositor_frame_sink.cc:57: base::Bind(&CompositorFrameSink::SubmitCompositorFrameAck, On 2016/10/11 02:43:25, sky wrote: > Any idea ...
4 years, 2 months ago (2016-10-13 22:02:48 UTC) #24
danakj
PTAL sunny https://codereview.chromium.org/2409923002/diff/60001/cc/output/compositor_frame_sink_client.h File cc/output/compositor_frame_sink_client.h (right): https://codereview.chromium.org/2409923002/diff/60001/cc/output/compositor_frame_sink_client.h#newcode39 cc/output/compositor_frame_sink_client.h:39: // unregisted by giving a null base::Closure. ...
4 years, 2 months ago (2016-10-13 23:50:23 UTC) #26
sunnyps
lgtm % nits https://codereview.chromium.org/2409923002/diff/100001/cc/scheduler/scheduler_state_machine.cc File cc/scheduler/scheduler_state_machine.cc (right): https://codereview.chromium.org/2409923002/diff/100001/cc/scheduler/scheduler_state_machine.cc#newcode357 cc/scheduler/scheduler_state_machine.cc:357: // Do not queue too many ...
4 years, 2 months ago (2016-10-14 01:08:47 UTC) #28
danakj
Done but https://codereview.chromium.org/2409923002/diff/100001/cc/scheduler/scheduler_unittest.cc File cc/scheduler/scheduler_unittest.cc (right): https://codereview.chromium.org/2409923002/diff/100001/cc/scheduler/scheduler_unittest.cc#newcode1499 cc/scheduler/scheduler_unittest.cc:1499: void SchedulerTest::ImplFrameSkippedAfterLateAck( On 2016/10/14 01:08:47, sunnyps wrote: ...
4 years, 2 months ago (2016-10-14 01:19:31 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409923002/120001
4 years, 2 months ago (2016-10-14 01:21:00 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/295449)
4 years, 2 months ago (2016-10-14 01:24:38 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409923002/140001
4 years, 2 months ago (2016-10-14 01:55:57 UTC) #37
commit-bot: I haz the power
Committed patchset #6 (id:140001)
4 years, 2 months ago (2016-10-14 03:16:08 UTC) #39
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 03:18:08 UTC) #41
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/9d124421c3113ae9e87d92570a0d187a72d4154a
Cr-Commit-Position: refs/heads/master@{#425245}

Powered by Google App Engine
This is Rietveld 408576698