Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2403363003: [Merge to 2883] Revert "[scheduler] Teach scheduler about audio state" (Closed)

Created:
4 years, 2 months ago by erikchen
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

[Merge to 2883] Revert "[scheduler] Teach scheduler about audio state" > > This patch wires information about audio state to renderer scheduler > > and stops all throttling (background and offscreen) while > > audio is playing and for a short period after audio is stopped. > > > > BUG=642321, 616519 > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > > > Committed: https://crrev.com/a7a651d546b76499821b4ba47b8f017d4b8becac > > Cr-Commit-Position: refs/heads/master@{#423405} > > BUG=653865, 642321, 616519 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > TBR=clamy@chromium.org, skyostil@chromium.org, dcheng@chromium.org, alexclarke@chromium.org > > Review-Url: https://codereview.chromium.org/2408003002 > Cr-Commit-Position: refs/heads/master@{#424334} > (cherry picked from commit ab94f97287e2649a65b633fe8e5d841ff2a65716) Committed: https://chromium.googlesource.com/chromium/src/+/d0175120266fb9eaf5068312e164e21cc1767c6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -248 lines) Patch
M cc/test/ordered_simple_task_runner.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/media/audio_stream_monitor.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M content/common/page_messages.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/browser/web_contents.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h View 6 chunks +1 line, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc View 8 chunks +2 lines, -77 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h View 2 chunks +4 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc View 10 chunks +45 lines, -61 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h View 3 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc View 3 chunks +1 line, -11 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/public/platform/WebViewScheduler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebView.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
erikchen
4 years, 2 months ago (2016-10-11 01:55:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d0175120266fb9eaf5068312e164e21cc1767c6d.

Powered by Google App Engine
This is Rietveld 408576698