Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2408003002: Revert "[scheduler] Teach scheduler about audio state" (Closed)

Created:
4 years, 2 months ago by erikchen
Modified:
4 years, 2 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, blink-reviews-api_chromium.org, feature-media-reviews_chromium.org, dglazkov+blink, darin-cc_chromium.org, blink-reviews, cc-bugs_chromium.org, scheduler-bugs_chromium.org, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "[scheduler] Teach scheduler about audio state" > This patch wires information about audio state to renderer scheduler > and stops all throttling (background and offscreen) while > audio is playing and for a short period after audio is stopped. > > BUG=642321, 616519 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/a7a651d546b76499821b4ba47b8f017d4b8becac > Cr-Commit-Position: refs/heads/master@{#423405} BUG=653865, 642321, 616519 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=clamy@chromium.org, skyostil@chromium.org, dcheng@chromium.org, alexclarke@chromium.org Committed: https://crrev.com/ab94f97287e2649a65b633fe8e5d841ff2a65716 Cr-Commit-Position: refs/heads/master@{#424334}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -248 lines) Patch
M cc/test/ordered_simple_task_runner.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/media/audio_stream_monitor.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 chunks +2 lines, -9 lines 0 comments Download
M content/common/page_messages.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/browser/web_contents.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h View 6 chunks +1 line, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc View 8 chunks +2 lines, -77 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h View 2 chunks +4 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc View 10 chunks +45 lines, -61 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h View 3 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc View 3 chunks +1 line, -11 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/public/platform/WebViewScheduler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebView.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
erikchen
4 years, 2 months ago (2016-10-10 23:48:26 UTC) #6
Sami
On 2016/10/10 23:48:26, erikchen wrote: Is this a speculative revert in addition to https://chromium.googlesource.com/chromium/src.git/+/b4702b576414fc5f06bb20454988d0705fba9e9e?
4 years, 2 months ago (2016-10-11 00:04:05 UTC) #7
erikchen
On 2016/10/11 00:04:05, Sami (slow -- traveling) wrote: > On 2016/10/10 23:48:26, erikchen wrote: > ...
4 years, 2 months ago (2016-10-11 00:04:56 UTC) #8
erikchen
On 2016/10/11 00:04:56, erikchen wrote: > On 2016/10/11 00:04:05, Sami (slow -- traveling) wrote: > ...
4 years, 2 months ago (2016-10-11 00:17:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408003002/20001
4 years, 2 months ago (2016-10-11 00:17:48 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-11 01:35:25 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 01:37:56 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab94f97287e2649a65b633fe8e5d841ff2a65716
Cr-Commit-Position: refs/heads/master@{#424334}

Powered by Google App Engine
This is Rietveld 408576698