Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2403213002:
[MR UI] Fix the size of the focus shadow on a checkbox in MR dialog (Closed)
DescriptionFix the size of the focus shadow on a checkbox in MR dialog
This CL undoes the change in the size of the focus shadow on a checkbox in the first run flow, introduced by an update [1] to Polymer.
I've uploaded a screenshot of the checkbox with this fix to the bug thread.
[1] https://codereview.chromium.org/2314283002
BUG=654332
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/079426cf1940176c4a9307e3ef1b60e34135ea03
Cr-Commit-Position: refs/heads/master@{#424355}
Patch Set 1 #
Messages
Total messages: 22 (16 generated)
Description was changed from ========== . BUG= ========== to ========== . BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== . BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Fix the size of the focus shadow in MR dialog This CL undoes the change in the size of the focus shadow in the first run flow, introduced by a change [1] to Polymer. [1] https://codereview.chromium.org/2314283002 BUG=654332 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Fix the size of the focus shadow in MR dialog This CL undoes the change in the size of the focus shadow in the first run flow, introduced by a change [1] to Polymer. [1] https://codereview.chromium.org/2314283002 BUG=654332 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Fix the size of the focus shadow in MR dialog This CL undoes the change in the size of the focus shadow in the first run flow, introduced by an update [1] to Polymer. [1] https://codereview.chromium.org/2314283002 BUG=654332 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Fix the size of the focus shadow in MR dialog This CL undoes the change in the size of the focus shadow in the first run flow, introduced by an update [1] to Polymer. [1] https://codereview.chromium.org/2314283002 BUG=654332 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Fix the size of the focus shadow in MR dialog This CL undoes the change in the size of the focus shadow on a checkbox in the first run flow, introduced by an update [1] to Polymer. [1] https://codereview.chromium.org/2314283002 BUG=654332 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Fix the size of the focus shadow in MR dialog This CL undoes the change in the size of the focus shadow on a checkbox in the first run flow, introduced by an update [1] to Polymer. [1] https://codereview.chromium.org/2314283002 BUG=654332 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Fix the size of the focus shadow on a checkbox in MR dialog This CL undoes the change in the size of the focus shadow on a checkbox in the first run flow, introduced by an update [1] to Polymer. [1] https://codereview.chromium.org/2314283002 BUG=654332 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Fix the size of the focus shadow on a checkbox in MR dialog This CL undoes the change in the size of the focus shadow on a checkbox in the first run flow, introduced by an update [1] to Polymer. [1] https://codereview.chromium.org/2314283002 BUG=654332 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Fix the size of the focus shadow on a checkbox in MR dialog This CL undoes the change in the size of the focus shadow on a checkbox in the first run flow, introduced by an update [1] to Polymer. I've uploaded a screenshot of the checkbox with this fix to the bug thread. [1] https://codereview.chromium.org/2314283002 BUG=654332 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Patchset #1 (id:1) has been deleted
takumif@chromium.org changed reviewers: + imcheng@chromium.org
Please take a look, thank you!
dbeam@chromium.org changed reviewers: + dbeam@chromium.org
yep, that's the fix, sorry for the break lgtm
lgtm
The CQ bit was checked by takumif@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by takumif@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix the size of the focus shadow on a checkbox in MR dialog This CL undoes the change in the size of the focus shadow on a checkbox in the first run flow, introduced by an update [1] to Polymer. I've uploaded a screenshot of the checkbox with this fix to the bug thread. [1] https://codereview.chromium.org/2314283002 BUG=654332 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Fix the size of the focus shadow on a checkbox in MR dialog This CL undoes the change in the size of the focus shadow on a checkbox in the first run flow, introduced by an update [1] to Polymer. I've uploaded a screenshot of the checkbox with this fix to the bug thread. [1] https://codereview.chromium.org/2314283002 BUG=654332 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix the size of the focus shadow on a checkbox in MR dialog This CL undoes the change in the size of the focus shadow on a checkbox in the first run flow, introduced by an update [1] to Polymer. I've uploaded a screenshot of the checkbox with this fix to the bug thread. [1] https://codereview.chromium.org/2314283002 BUG=654332 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Fix the size of the focus shadow on a checkbox in MR dialog This CL undoes the change in the size of the focus shadow on a checkbox in the first run flow, introduced by an update [1] to Polymer. I've uploaded a screenshot of the checkbox with this fix to the bug thread. [1] https://codereview.chromium.org/2314283002 BUG=654332 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/079426cf1940176c4a9307e3ef1b60e34135ea03 Cr-Commit-Position: refs/heads/master@{#424355} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/079426cf1940176c4a9307e3ef1b60e34135ea03 Cr-Commit-Position: refs/heads/master@{#424355} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
