Roll Polymer

Roll Polymer

R=tsergeant@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/07ee8d7b43baca2fced02d938a14e75c158f45ce
Cr-Commit-Position: refs/heads/master@{#416960}

[Dan Beam, 2016-09-06 22:14:30]

Description was changed from

==========
Roll Polymer

R=michaelpg@chromium.org
BUG=none
==========

to

==========
Roll Polymer

R=michaelpg@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-09-06 22:24:34]

Description was changed from

==========
Roll Polymer

R=michaelpg@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Roll Polymer

R=tsergeant@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-09-06 22:24:35]

dbeam@chromium.org changed reviewers:
+ tsergeant@chromium.org
- michaelpg@chromium.org

[Dan Beam, 2016-09-06 22:24:45]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 22:25:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 22:28:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 22:28:34]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tsergeant, 2016-09-06 22:35:37]

Patch failure looks like it might be to do with polymer-css-build. Have you
rebased past that CL?

[Dan Beam, 2016-09-06 23:14:36]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 23:14:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-09-06 23:15:08]

On 2016/09/06 22:35:37, tsergeant wrote:
> Patch failure looks like it might be to do with polymer-css-build. Have you
> rebased past that CL?

yep, we figured out the issue:
https://codereview.chromium.org/2316833002/

didn't have polymer-css-build installed.

new patchset should be fixed.

[tsergeant, 2016-09-06 23:20:06]

lgtm

[commit-bot: I haz the power, 2016-09-07 00:49:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 00:49:15]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2016-09-07 01:17:33]

A new var will be needed for the checkbox ripple.
A good place to add it would be settings_vars_css.html
for MD settings.

--paper-checkbox-ink-size: 40px; 

looks pretty good imo. It can be part of this CL or
another CL, this is just an FYI/heads-up.

[Dan Beam, 2016-09-07 05:26:02]

On 2016/09/07 01:17:33, dschuyler wrote:
> A new var will be needed for the checkbox ripple.
> A good place to add it would be settings_vars_css.html
> for MD settings.
> 
> --paper-checkbox-ink-size: 40px; 
> 
> looks pretty good imo. It can be part of this CL or
> another CL, this is just an FYI/heads-up.

a pre-cursor so I don't accidentally get tons of bugs logged on me for the day
this might be broken:
https://codereview.chromium.org/2316013002/

[Dan Beam, 2016-09-07 05:26:09]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 05:26:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 06:40:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 06:40:22]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-09-07 16:32:53]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-09-07 16:32:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2314283002/#ps40001
(title: "dep")

[commit-bot: I haz the power, 2016-09-07 16:33:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 16:38:36]

Description was changed from

==========
Roll Polymer

R=tsergeant@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Roll Polymer

R=tsergeant@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-09-07 16:38:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-07 16:41:30]

Description was changed from

==========
Roll Polymer

R=tsergeant@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Roll Polymer

R=tsergeant@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/07ee8d7b43baca2fced02d938a14e75c158f45ce
Cr-Commit-Position: refs/heads/master@{#416960}
==========

[commit-bot: I haz the power, 2016-09-07 16:41:31]

Patchset 3 (id:??) landed as
https://crrev.com/07ee8d7b43baca2fced02d938a14e75c158f45ce
Cr-Commit-Position: refs/heads/master@{#416960}