Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 24032002: Revert 221596 "Re-enable TouchCursorInTextfieldTest with some fi..." (Closed)

Created:
7 years, 3 months ago by henrika (OOO until Aug 14)
Modified:
7 years, 3 months ago
Reviewers:
mohsen
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 221596 "Re-enable TouchCursorInTextfieldTest with some fi..." > Re-enable TouchCursorInTextfieldTest with some fixes and logs > > Re-enabled TouchEditableImplAuraTest.TouchCursorInTextfieldTest with two > fixes: > - Changed focus_textfield() in touch_seleciton.html to collapse > selection after focus, since nothing should be selected after > focusing the textfield. > - Added a wait between dragging the handle and getting the cursor > position in the test to be sure that the cursor position is updated > completely. > Also, added some logs in the test so that if it failed again, more data > is available for investigation. > > BUG=235991 > > Review URL: https://chromiumcodereview.appspot.com/23823004 TBR=mohsen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221653

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -17 lines) Patch
M trunk/src/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc View 4 chunks +4 lines, -15 lines 0 comments Download
M trunk/src/content/test/data/touch_selection.html View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
henrika (OOO until Aug 14)
7 years, 3 months ago (2013-09-06 08:55:08 UTC) #1
henrika (OOO until Aug 14)
Committed patchset #1 manually as r221653.
7 years, 3 months ago (2013-09-06 08:55:18 UTC) #2
henrika (OOO until Aug 14)
7 years, 3 months ago (2013-09-06 08:59:41 UTC) #3
Message was sent while issue was closed.
See
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...
for details.

Powered by Google App Engine
This is Rietveld 408576698