Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: trunk/src/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

Issue 24032002: Revert 221596 "Re-enable TouchCursorInTextfieldTest with some fi..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/content/test/data/touch_selection.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc
===================================================================
--- trunk/src/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc (revision 221652)
+++ trunk/src/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc (working copy)
@@ -294,7 +294,6 @@
EXPECT_TRUE(touch_editable->touch_selection_controller_.get());
}
- // TODO(mohsen): Remove logs if the test showed no flakiness anymore.
void TestTouchCursorInTextfield() {
ASSERT_NO_FATAL_FAILURE(
StartTestWithPage("files/touch_selection.html"));
@@ -312,28 +311,21 @@
aura::test::EventGenerator generator(content->GetRootWindow(), content);
gfx::Rect bounds = content->GetBoundsInRootWindow();
EXPECT_EQ(touch_editable->rwhva_, rwhva);
-
- LOG(INFO) << "Focus the textfield.";
ExecuteSyncJSFunction(view_host, "focus_textfield()");
// Tap textfield
touch_editable->Reset();
- LOG(INFO) << "Tap in the textfield.";
generator.GestureTapAt(gfx::Point(bounds.x() + 50, bounds.y() + 40));
- LOG(INFO) << "Wait for tap-down ACK.";
touch_editable->WaitForGestureAck(); // Wait for Tap Down Ack
touch_editable->Reset();
- LOG(INFO) << "Wait for tap ACK.";
touch_editable->WaitForGestureAck(); // Wait for Tap Ack.
- LOG(INFO) << "Test the touch selection handle.";
// Check if cursor handle is showing.
ui::TouchSelectionController* controller =
touch_editable->touch_selection_controller_.get();
EXPECT_NE(ui::TEXT_INPUT_TYPE_NONE, touch_editable->text_input_type_);
EXPECT_TRUE(controller);
- LOG(INFO) << "Test cursor position.";
scoped_ptr<base::Value> value =
content::ExecuteScriptAndGetValue(view_host, "get_cursor_position()");
int cursor_pos = -1;
@@ -341,18 +333,14 @@
EXPECT_NE(-1, cursor_pos);
// Move the cursor handle.
- LOG(INFO) << "Drag the touch selection handle to change its position.";
generator.GestureScrollSequence(
gfx::Point(50, 59),
gfx::Point(10, 59),
base::TimeDelta::FromMilliseconds(20),
1);
- LOG(INFO) << "Wait for cursor position to change.";
- touch_editable->WaitForSelectionChangeCallback();
- LOG(INFO) << "Check cursor position is changed.";
EXPECT_TRUE(touch_editable->touch_selection_controller_.get());
- value = content::ExecuteScriptAndGetValue(view_host,
- "get_cursor_position()");
+ value = content::ExecuteScriptAndGetValue(
+ view_host, "get_cursor_position()");
int new_cursor_pos = -1;
value->GetAsInteger(&new_cursor_pos);
EXPECT_NE(-1, new_cursor_pos);
@@ -379,8 +367,9 @@
TestTouchSelectionOnLongPress();
}
+// TODO(miu): Disabled test due to flakiness. http://crbug.com/235991
IN_PROC_BROWSER_TEST_F(TouchEditableImplAuraTest,
- TouchCursorInTextfieldTest) {
+ DISABLED_TouchCursorInTextfieldTest) {
TestTouchCursorInTextfield();
}
« no previous file with comments | « no previous file | trunk/src/content/test/data/touch_selection.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698