Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 240313002: Revert 264167 "Sniff MIME type for files which have unknown exte..." (Closed)

Created:
6 years, 8 months ago by yoshiki
Modified:
6 years, 8 months ago
Reviewers:
yoshiki
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 264167 "Sniff MIME type for files which have unknown exte..." This revert is requested by fukino, who is the author of the patch. This patch breaks a browser test on Windows. > Sniff MIME type for files which have unknown extensions. > > What I want to do: > Open text files which have unknown extensions(e.g. access.log.1) using packaged apps which can handle 'text/plain'(e.g. Text, Caret,...). > > Current situation: > By following reasons, text files with unknow extension can't be opened. > 1. FileManager guess the MIME type as empty, so 'text/plain'-supporting apps are not shown as handlers. > 2. PlatformAppLauncher guess the MIME type as 'application/octet-stream', and it launch apps with no data because those apps don't handle 'application/octet-stream'. > > What I changed: > Modified FileManager and PlatformAppLauncher to sniff MIME types if they are unknown based on extensions. > > BUG=352250 > R=benwells@chromium.org, hashimoto@chromium.org, jorgelo@chromium.org > > Review URL: https://codereview.chromium.org/224883008 > > Patch from Naoki Fukino <fukino@chromium.org>;. TBR=yoshiki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264192

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -106 lines) Patch
M trunk/src/apps/launcher.cc View 2 chunks +2 lines, -17 lines 0 comments Download
M trunk/src/chrome/browser/apps/app_browsertest.cc View 1 chunk +1 line, -9 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.h View 2 chunks +0 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc View 5 chunks +8 lines, -57 lines 0 comments Download
M trunk/src/chrome/test/data/extensions/platform_apps/launch_application_octet_stream/test.js View 1 chunk +12 lines, -1 line 0 comments Download
D trunk/src/chrome/test/data/extensions/platform_apps/launch_files/test_binary.unknownextension View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
yoshiki
6 years, 8 months ago (2014-04-16 13:57:47 UTC) #1
yoshiki
6 years, 8 months ago (2014-04-16 14:04:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r264192 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698