Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: trunk/src/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc

Issue 240313002: Revert 264167 "Sniff MIME type for files which have unknown exte..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
===================================================================
--- trunk/src/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc (revision 264191)
+++ trunk/src/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc (working copy)
@@ -9,18 +9,14 @@
#include <vector>
#include "chrome/browser/chromeos/drive/file_system_util.h"
+#include "chrome/browser/chromeos/file_manager/file_tasks.h"
#include "chrome/browser/chromeos/file_manager/fileapi_util.h"
#include "chrome/browser/chromeos/file_manager/mime_util.h"
#include "chrome/browser/chromeos/fileapi/file_system_backend.h"
#include "chrome/browser/profiles/profile.h"
-#include "content/public/browser/browser_thread.h"
-#include "net/base/filename_util.h"
-#include "net/base/mime_sniffer.h"
#include "webkit/browser/fileapi/file_system_context.h"
#include "webkit/browser/fileapi/file_system_url.h"
-using content::BrowserThread;
-using extensions::app_file_handler_util::PathAndMimeTypeSet;
using fileapi::FileSystemURL;
namespace extensions {
@@ -58,33 +54,6 @@
return mime_types;
}
-void SniffMimeType(PathAndMimeTypeSet* path_mime_set,
- std::vector<GURL>* file_urls) {
- PathAndMimeTypeSet sniffed_path_mime_set;
- std::vector<char> content(net::kMaxBytesToSniff);
-
- // For each files, sniff its MIME type if it is empty
- for (PathAndMimeTypeSet::iterator it = path_mime_set->begin();
- it != path_mime_set->end();
- ++it) {
- const base::FilePath& file_path = it->first;
- std::string mime_type = it->second;
- // Note: sniff MIME type only for local files.
- if (mime_type.empty() && !drive::util::IsUnderDriveMountPoint(file_path)) {
- int bytes_read = base::ReadFile(file_path, &content[0], content.size());
- if (bytes_read >= 0) {
- net::SniffMimeType(&content[0],
- bytes_read,
- net::FilePathToFileURL(file_path),
- std::string(), // type_hint (passes no hint)
- &mime_type);
- }
- }
- sniffed_path_mime_set.insert(std::make_pair(file_path, mime_type));
- }
- path_mime_set->swap(sniffed_path_mime_set);
-}
-
} // namespace
bool FileBrowserPrivateExecuteTaskFunction::RunImpl() {
@@ -165,8 +134,8 @@
// Collect all the URLs, convert them to GURLs, and crack all the urls into
// file paths.
- scoped_ptr<PathAndMimeTypeSet> path_mime_set(new PathAndMimeTypeSet);
- scoped_ptr<std::vector<GURL> > file_urls(new std::vector<GURL>);
+ extensions::app_file_handler_util::PathAndMimeTypeSet path_mime_set;
+ std::vector<GURL> file_urls;
for (size_t i = 0; i < params->file_urls.size(); ++i) {
std::string mime_type;
if (params->mime_types.size() != 0)
@@ -179,40 +148,21 @@
continue;
const base::FilePath file_path = file_system_url.path();
- file_urls->push_back(file_url);
+ file_urls.push_back(file_url);
// If MIME type is not provided, guess it from the file path.
if (mime_type.empty())
mime_type = file_manager::util::GetMimeTypeForPath(file_path);
- path_mime_set->insert(std::make_pair(file_path, mime_type));
+ path_mime_set.insert(std::make_pair(file_path, mime_type));
}
- // In case the MIME type of some files are empty,
- // try to sniff their MIME type by their content.
- PathAndMimeTypeSet* path_mime_set_ptr = path_mime_set.get();
- std::vector<GURL>* file_urls_ptr = file_urls.get();
-
- BrowserThread::PostBlockingPoolTaskAndReply(
- FROM_HERE,
- base::Bind(&SniffMimeType, path_mime_set_ptr, file_urls_ptr),
- base::Bind(
- &FileBrowserPrivateGetFileTasksFunction::OnSniffingMimeTypeCompleted,
- this,
- base::Passed(&path_mime_set),
- base::Passed(&file_urls)));
- return true;
-}
-
-void FileBrowserPrivateGetFileTasksFunction::OnSniffingMimeTypeCompleted(
- scoped_ptr<PathAndMimeTypeSet> path_mime_set,
- scoped_ptr<std::vector<GURL> > file_urls) {
std::vector<file_manager::file_tasks::FullTaskDescriptor> tasks;
file_manager::file_tasks::FindAllTypesOfTasks(
GetProfile(),
drive::util::GetDriveAppRegistryByProfile(GetProfile()),
- *path_mime_set,
- *file_urls,
+ path_mime_set,
+ file_urls,
&tasks);
// Convert the tasks into JSON compatible objects.
@@ -232,6 +182,7 @@
results_ = extensions::api::file_browser_private::GetFileTasks::Results::
Create(results);
SendResponse(true);
+ return true;
}
bool FileBrowserPrivateSetDefaultTaskFunction::RunImpl() {

Powered by Google App Engine
This is Rietveld 408576698