Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1496)

Unified Diff: src/wasm/signature-map.h

Issue 2403093002: [wasm] Canonicalize function signature indices for matching in indirect calls. (Closed)
Patch Set: Add TODO for myself Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/wasm/signature-map.h
diff --git a/src/wasm/signature-map.h b/src/wasm/signature-map.h
new file mode 100644
index 0000000000000000000000000000000000000000..7c9b6f5e8b2bddd57b91417ac84e2eff1357f978
--- /dev/null
+++ b/src/wasm/signature-map.h
@@ -0,0 +1,40 @@
+// Copyright 2016 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef V8_WASM_SIGNATURE_MAP_H_
+#define V8_WASM_SIGNATURE_MAP_H_
+
+#include <map>
+
+#include "src/signature.h"
+#include "src/wasm/wasm-opcodes.h"
+
+namespace v8 {
+namespace internal {
+namespace wasm {
+
+// A signature map canonicalizes signatures into a range of indices so that
+// two different {FunctionSig} instances with the same contents map to the
+// same index.
+class SignatureMap {
+ public:
+ // Gets the index for a signature, assigning a new index if necessary.
+ uint32_t Get(FunctionSig* sig);
+
+ // Gets the index for a signature, returning {-1} if not found.
+ int32_t Find(FunctionSig* sig) const;
+
+ private:
+ struct CompareFunctionSigs {
+ bool operator()(FunctionSig* a, FunctionSig* b) const;
+ };
+ uint32_t next_;
+ std::map<FunctionSig*, uint32_t, CompareFunctionSigs> map_;
Clemens Hammacher 2016/10/10 17:35:02 Depending on the size of the map, an std::unordere
titzer 2016/10/10 17:45:21 I've added a TODO here (since it was much easier t
+};
+
+} // namespace wasm
+} // namespace internal
+} // namespace v8
+
+#endif // V8_WASM_SIGNATURE_MAP_H_

Powered by Google App Engine
This is Rietveld 408576698