Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2403053002: [Cronet] Add new API methods before removing old ones (Closed)

Created:
4 years, 2 months ago by pauljensen
Modified:
4 years, 2 months ago
Reviewers:
kapishnikov
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

[Cronet] Add new API methods before removing old ones To allow embedders to update to the new API piecemeal, rather than forcing an all-at-once update: 1. Allow mocking of UrlRequest.Builder by making non-final. This allows embedders to prepare for removal of CronetEngine.createRequest(). 2. Add CronetEngine.newUrlRequestBuilder() R=kapishnikov BUG=654432 Review-Url: https://codereview.chromium.org/2402753002 Cr-Commit-Position: refs/heads/master@{#424154} (cherry picked from commit 4480e95462fa0a4a59f7ba517a5fde5262aa8801) Committed: https://chromium.googlesource.com/chromium/src/+/94b92e7ee8b2a5a266ba40298abb801119632fd8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M components/cronet/android/api/src/org/chromium/net/CronetEngine.java View 1 chunk +16 lines, -0 lines 0 comments Download
M components/cronet/android/api/src/org/chromium/net/UrlRequest.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
pauljensen
4 years, 2 months ago (2016-10-10 15:56:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
94b92e7ee8b2a5a266ba40298abb801119632fd8.

Powered by Google App Engine
This is Rietveld 408576698