Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 2402753002: [Cronet] Add new API methods before removing old ones (Closed)

Created:
4 years, 2 months ago by pauljensen
Modified:
4 years, 2 months ago
Reviewers:
kapishnikov
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Add new API methods before removing old ones To allow embedders to update to the new API piecemeal, rather than forcing an all-at-once update: 1. Allow mocking of UrlRequest.Builder by making non-final. This allows embedders to prepare for removal of CronetEngine.createRequest(). 2. Add CronetEngine.newUrlRequestBuilder() R=kapishnikov BUG=654432 Committed: https://crrev.com/4480e95462fa0a4a59f7ba517a5fde5262aa8801 Cr-Commit-Position: refs/heads/master@{#424154}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M components/cronet/android/api/src/org/chromium/net/CronetEngine.java View 1 chunk +16 lines, -0 lines 0 comments Download
M components/cronet/android/api/src/org/chromium/net/UrlRequest.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
pauljensen
Andrei, PTAL, thank you! I imagine we could get this merged to M55 easily.
4 years, 2 months ago (2016-10-07 19:00:00 UTC) #1
kapishnikov
lgtm
4 years, 2 months ago (2016-10-10 15:15:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2402753002/1
4 years, 2 months ago (2016-10-10 15:25:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 15:33:47 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 15:36:14 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4480e95462fa0a4a59f7ba517a5fde5262aa8801
Cr-Commit-Position: refs/heads/master@{#424154}

Powered by Google App Engine
This is Rietveld 408576698