[wasm] Do not create TF nodes during verification

[wasm] Do not create TF nodes during verification

BUG=chromium:654377
TEST=mjsunit/regress/wasm/regression-654377
R=titzer@chromium.org

Committed: https://crrev.com/0e1f6d8bfc62a09163a758322bd26a3e8696ef2c
Cr-Commit-Position: refs/heads/master@{#40246}

[ahaas, 2016-10-10 14:14:32]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 14:14:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2016-10-10 14:16:42]

https://codereview.chromium.org/2403013002/diff/1/src/wasm/ast-decoder.cc
File src/wasm/ast-decoder.cc (right):

https://codereview.chromium.org/2403013002/diff/1/src/wasm/ast-decoder.cc#new...
src/wasm/ast-decoder.cc:833: if (build()) {
I don't think this is right place to fix it; it should be deeper inside of
BreakTo().

[commit-bot: I haz the power, 2016-10-10 14:28:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 14:28:54]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[ahaas, 2016-10-11 09:50:24]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 09:50:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 10:15:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 10:15:25]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-10-12 10:47:52]

On 2016/10/10 at 14:16:42, titzer wrote:
> https://codereview.chromium.org/2403013002/diff/1/src/wasm/ast-decoder.cc
> File src/wasm/ast-decoder.cc (right):
> 
>
https://codereview.chromium.org/2403013002/diff/1/src/wasm/ast-decoder.cc#new...
> src/wasm/ast-decoder.cc:833: if (build()) {
> I don't think this is right place to fix it; it should be deeper inside of
BreakTo().

PTAL, I only guard CreateOrMergeIntoPhi now.

[titzer, 2016-10-12 10:51:48]

lgtm

[ahaas, 2016-10-13 07:51:30]

The CQ bit was checked by ahaas@chromium.org

[commit-bot: I haz the power, 2016-10-13 07:51:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 08:21:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-13 08:21:57]

Description was changed from

==========
[wasm] Do not create TF nodes during verification

BUG=chromium:654377
TEST=mjsunit/regress/wasm/regression-654377
R=titzer@chromium.org
==========

to

==========
[wasm] Do not create TF nodes during verification

BUG=chromium:654377
TEST=mjsunit/regress/wasm/regression-654377
R=titzer@chromium.org

Committed: https://crrev.com/0e1f6d8bfc62a09163a758322bd26a3e8696ef2c
Cr-Commit-Position: refs/heads/master@{#40246}
==========

[commit-bot: I haz the power, 2016-10-13 08:21:58]

Patchset 2 (id:??) landed as
https://crrev.com/0e1f6d8bfc62a09163a758322bd26a3e8696ef2c
Cr-Commit-Position: refs/heads/master@{#40246}