Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: src/wasm/ast-decoder.cc

Issue 2403013002: [wasm] Do not create TF nodes during verification (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/wasm/regression-654377.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/signature.h" 5 #include "src/signature.h"
6 6
7 #include "src/bit-vector.h" 7 #include "src/bit-vector.h"
8 #include "src/flags.h" 8 #include "src/flags.h"
9 #include "src/handles.h" 9 #include "src/handles.h"
10 #include "src/zone/zone-containers.h" 10 #include "src/zone/zone-containers.h"
(...skipping 812 matching lines...) Expand 10 before | Expand all | Expand 10 after
823 Push(tval.type, phi); 823 Push(tval.type, phi);
824 ssa_env_->control = merge; 824 ssa_env_->control = merge;
825 } else { 825 } else {
826 Push(tval.type, nullptr); 826 Push(tval.type, nullptr);
827 } 827 }
828 break; 828 break;
829 } 829 }
830 case kExprBr: { 830 case kExprBr: {
831 BreakDepthOperand operand(this, pc_); 831 BreakDepthOperand operand(this, pc_);
832 if (Validate(pc_, operand, control_)) { 832 if (Validate(pc_, operand, control_)) {
833 BreakTo(operand.depth); 833 if (build()) {
titzer 2016/10/10 14:16:41 I don't think this is right place to fix it; it sh
834 BreakTo(operand.depth);
835 }
834 } 836 }
835 len = 1 + operand.length; 837 len = 1 + operand.length;
836 EndControl(); 838 EndControl();
837 break; 839 break;
838 } 840 }
839 case kExprBrIf: { 841 case kExprBrIf: {
840 BreakDepthOperand operand(this, pc_); 842 BreakDepthOperand operand(this, pc_);
841 Value cond = Pop(0, kAstI32); 843 Value cond = Pop(0, kAstI32);
842 if (ok() && Validate(pc_, operand, control_)) { 844 if (ok() && Validate(pc_, operand, control_)) {
843 SsaEnv* fenv = ssa_env_; 845 SsaEnv* fenv = ssa_env_;
(...skipping 1092 matching lines...) Expand 10 before | Expand all | Expand 10 after
1936 BitVector* AnalyzeLoopAssignmentForTesting(Zone* zone, size_t num_locals, 1938 BitVector* AnalyzeLoopAssignmentForTesting(Zone* zone, size_t num_locals,
1937 const byte* start, const byte* end) { 1939 const byte* start, const byte* end) {
1938 FunctionBody body = {nullptr, nullptr, nullptr, start, end}; 1940 FunctionBody body = {nullptr, nullptr, nullptr, start, end};
1939 WasmFullDecoder decoder(zone, nullptr, body); 1941 WasmFullDecoder decoder(zone, nullptr, body);
1940 return decoder.AnalyzeLoopAssignmentForTesting(start, num_locals); 1942 return decoder.AnalyzeLoopAssignmentForTesting(start, num_locals);
1941 } 1943 }
1942 1944
1943 } // namespace wasm 1945 } // namespace wasm
1944 } // namespace internal 1946 } // namespace internal
1945 } // namespace v8 1947 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/wasm/regression-654377.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698