Add check for file:-navigations from PDFs

chrome/test/data/pdf/navigator_test.js

Index: chrome/test/data/pdf/navigator_test.js
diff --git a/chrome/test/data/pdf/navigator_test.js b/chrome/test/data/pdf/navigator_test.js
index f589016547a0f0f01df07237ae5d3f9784a45478..dd990d998377c3d7b7ea318536544055085db979 100644
--- a/chrome/test/data/pdf/navigator_test.js
+++ b/chrome/test/data/pdf/navigator_test.js
@@ -12,16 +12,16 @@ function MockNavigatorDelegate() {
 MockNavigatorDelegate.prototype = {
   navigateInCurrentTab: function(url) {
     this.navigateInCurrentTabCalled = true;
-    this.url = url;
+    this.url = url || '<called, but no url set>';
   },
   navigateInNewTab: function(url) {
     this.navigateInNewTabCalled = true;
-    this.url = url;
+    this.url = url || '<called, but no url set>';
 
   },
   navigateInNewWindow: function(url) {
     this.navigateInNewWindowCalled = true;
-    this.url = url;
+    this.url = url || '<called, but no url set>';
   },
   reset: function() {
     this.navigateInCurrentTabCalled = false;
@@ -48,6 +48,10 @@ function doNavigationUrlTest(
   navigatorDelegate.reset();
   navigator.navigate(url, disposition);
   chrome.test.assertFalse(viewportChangedCallback.wasCalled);
+  chrome.test.assertEq(expectedResultUrl, navigatorDelegate.url);
+  if (expectedResultUrl === undefined) {
+    return;

[raymes, 2016/10/13 00:11:34]

Can we assert 
navigatorDelegate.navigateInCurrentTabCalled
navigatorDelegate.navigateInNewTabCalled
navigatorDelegate.navigateInNewWindowCalled

are all false in this case?

[robwu, 2016/10/13 07:22:35]

That is not needed, because url is undefined iff there is no navigation.
That is also why I modified the delegate above to include a default value for
url.

+  }
   switch (disposition) {
     case Navigator.WindowOpenDisposition.CURRENT_TAB:
       chrome.test.assertTrue(navigatorDelegate.navigateInCurrentTabCalled);
@@ -61,7 +65,6 @@ function doNavigationUrlTest(
     default:
       break;
   }
-  chrome.test.assertEq(expectedResultUrl, navigatorDelegate.url);
 }
 
 /**
@@ -253,6 +256,38 @@ var tests = [
         'file:///foodotcom/bar.pdf');
 
     chrome.test.succeed();
+  },
+
+  function testNavigateInvalidUrls() {
+    var url = 'https://example.com/some-web-document.pdf';
+
+    // From non-file: to file:
+    doNavigationUrlTests(
+        url,
+        'file:///bar.pdf',
+        undefined);
+
+    doNavigationUrlTests(
+        url,
+        'chrome://version',
+        undefined);
+
+    doNavigationUrlTests(
+        url,
+        'javascript:// this is not a document.pdf',
+        undefined);
+
+    doNavigationUrlTests(
+        url,
+        'this-is-not-a-valid-scheme://path.pdf',
+        undefined);
+
+    doNavigationUrlTests(
+        url,
+        '',
+        undefined);
+
+    chrome.test.succeed();
   }
 ];