chrome/browser/resources/pdf/pdf.js - Issue 2402873002: Add check for file:-navigations from PDFs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/pdf/pdf.js

Issue 2402873002: Add check for file:-navigations from PDFs (Closed)

Patch Set: Put logic at single location, add test Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/pdf/pdf.js

diff --git a/chrome/browser/resources/pdf/pdf.js b/chrome/browser/resources/pdf/pdf.js

index 9805660b562c34e82cae189e4670abaace68eb8e..6a8e564b56f568f4ffa5d1539e0f8322c4ef1ad3 100644

--- a/chrome/browser/resources/pdf/pdf.js

+++ b/chrome/browser/resources/pdf/pdf.js

@@ -233,10 +233,9 @@ function PDFViewer(browserApi) {

document.addEventListener('mouseout', this.handleMouseEvent_.bind(this));

var isInTab = this.browserApi_.getStreamInfo().tabId != -1;

- var isSourceFileUrl = this.originalUrl_.startsWith('file://');

this.navigator_ = new Navigator(

this.originalUrl_, this.viewport_, this.paramsParser_,

- new NavigatorDelegate(isInTab, isSourceFileUrl));

+ new NavigatorDelegate(isInTab));

this.viewportScroller_ =

new ViewportScroller(this.viewport_, this.plugin_, window);