Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 240273006: Revert of gpu: Add CHROMIUM_sync_query extension. (Closed)

Created:
6 years, 8 months ago by hayato
Modified:
6 years, 8 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Visibility:
Public.

Description

Revert of gpu: Add CHROMIUM_sync_query extension. (https://codereview.chromium.org/238933003/) Reason for revert: [gardening] Seems that QueryTest.SyncQueryBasic started to fail on Android Tests (dbug). http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29 http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/18673/steps/gl_tests/logs/stdio [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from QueryTest [ RUN ] QueryTest.SyncQueryBasic ../../gpu/command_buffer/tests/gl_query_unittest.cc:154: Failure Value of: GLTestHelper::HasExtension("GL_CHROMIUM_sync_query") Actual: false Expected: true [0417/014324:ERROR:gles2_cmd_decoder.cc(9542)] [GroupMarkerNotSet(crbug.com/242999)!:04B0A600]GL ERROR :GL_INVALID_OPERATION : glBeginQueryEXT: not enabled for commands completed queries [0417/014324:ERROR:gles2_cmd_decoder.cc(9617)] [GroupMarkerNotSet(crbug.com/242999)!:04B0A600]GL ERROR :GL_INVALID_OPERATION : glEndQueryEXT: No active query ../../gpu/command_buffer/tests/gl_query_unittest.cc:166: Failure Value of: available Actual: false Expected: true ../../gpu/command_buffer/tests/gl_manager.cc:241: Failure Value of: glGetError() == GL_NONE Actual: false Expected: true [ FAILED ] QueryTest.SyncQueryBasic (70 ms) [----------] 1 test from QueryTest (71 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (71 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] QueryTest.SyncQueryBasic In range 264168:264191, this patch might be the culprit. Let me revert this patch and watch whether Android Tests will cycle to green or not. Original issue's description: > gpu: Add CHROMIUM_sync_query extension. > > This adds a GL_COMMANDS_COMPLETED_CHROMIUM query target that provide > a finer granularity of synchronizing GL command completion than offered > by glFinish(). > > BUG=269808, 356871, 273274 > TEST=gpu_unittests --gtest_filter=GLES2DecoderManualInitTest.BeginEndQueryEXTCommandsCompletedCHROMIUM > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264173 TBR=piman@chromium.org,epenner@chromium.org,sievers@chromium.org,reveman@chromium.org NOTREECHECKS=true NOTRY=true BUG=269808, 356871, 273274 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264407

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -236 lines) Patch
D gpu/GLES2/extensions/CHROMIUM/CHROMIUM_sync_query.txt View 1 chunk +0 lines, -53 lines 0 comments Download
M gpu/GLES2/gl2extchromium.h View 1 chunk +0 lines, -9 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 6 chunks +1 line, -9 lines 0 comments Download
M gpu/command_buffer/service/feature_info.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 6 chunks +1 line, -75 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 1 chunk +1 line, -2 lines 0 comments Download
M gpu/command_buffer/service/query_manager.cc View 3 chunks +0 lines, -53 lines 0 comments Download
M gpu/command_buffer/tests/gl_query_unittest.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M ui/gl/gl_bindings.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hayato
Created Revert of gpu: Add CHROMIUM_sync_query extension.
6 years, 8 months ago (2014-04-17 03:52:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/240273006/1
6 years, 8 months ago (2014-04-17 03:53:42 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-17 04:22:36 UTC) #3
Message was sent while issue was closed.
Change committed as 264407

Powered by Google App Engine
This is Rietveld 408576698