Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: trunk/src/chrome/browser/password_manager/password_form_manager.h

Issue 24024006: Revert 221424 "Save password functionality added to the save pas..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/password_manager/password_form_manager.h
===================================================================
--- trunk/src/chrome/browser/password_manager/password_form_manager.h (revision 221694)
+++ trunk/src/chrome/browser/password_manager/password_form_manager.h (working copy)
@@ -71,18 +71,6 @@
// the same thread!
bool HasCompletedMatching();
- // Sets current password to be saved when ApplyEdits() is called. Will
- // override a previous call to BlacklistPassword().
- void SavePassword();
-
- // Sets current password to be blacklisted when ApplyEdits() is called. Will
- // override a previous call to SavePassword().
- void BlacklistPassword();
-
- // Persist changes from the latest call to either SavePassword() or
- // BlacklistPassword().
- void ApplyChange();
-
// Determines if the user opted to 'never remember' passwords for this form.
bool IsBlacklisted();
@@ -117,8 +105,6 @@
// A user opted to 'never remember' passwords for this form.
// Blacklist it so that from now on when it is seen we ignore it.
-
- // TODO: Make this private once we switch to the new UI.
void PermanentlyBlacklist();
// If the user has submitted observed_form_, provisionally hold on to
@@ -134,8 +120,6 @@
// Handles save-as-new or update of the form managed by this manager.
// Note the basic data of updated_credentials must match that of
// observed_form_ (e.g DoesManage(pending_credentials_) == true).
-
- // TODO: Make this private once we switch to the new UI.
void Save();
// Call these if/when we know the form submission worked or failed.
@@ -307,8 +291,6 @@
ManagerAction manager_action_;
UserAction user_action_;
SubmitResult submit_result_;
- bool should_save_password_;
- bool should_blacklist_password_;
DISALLOW_COPY_AND_ASSIGN(PasswordFormManager);
};

Powered by Google App Engine
This is Rietveld 408576698