Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: trunk/src/chrome/browser/content_settings/tab_specific_content_settings.cc

Issue 24024006: Revert 221424 "Save password functionality added to the save pas..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/content_settings/tab_specific_content_settings.cc
===================================================================
--- trunk/src/chrome/browser/content_settings/tab_specific_content_settings.cc (revision 221694)
+++ trunk/src/chrome/browser/content_settings/tab_specific_content_settings.cc (working copy)
@@ -99,18 +99,6 @@
SiteDataObserver, observer_list_, ContentSettingsDestroyed());
}
-bool TabSpecificContentSettings::PasswordAccepted() {
- DCHECK(form_to_save_.get());
- form_to_save_->SavePassword();
- return true;
-}
-
-bool TabSpecificContentSettings::PasswordFormBlacklisted() {
- DCHECK(form_to_save_.get());
- form_to_save_->BlacklistPassword();
- return true;
-}
-
TabSpecificContentSettings* TabSpecificContentSettings::Get(
int render_process_id, int render_view_id) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
@@ -475,9 +463,9 @@
content::NotificationService::NoDetails());
}
+// TODO(npentrel): Save the password when user accepts the prompt
void TabSpecificContentSettings::OnPasswordSubmitted(
PasswordFormManager* form_to_save) {
- form_to_save_.reset(form_to_save);
OnContentAllowed(CONTENT_SETTINGS_TYPE_SAVE_PASSWORD);
NotifySiteDataObservers();
}
@@ -659,8 +647,6 @@
void TabSpecificContentSettings::DidNavigateMainFrame(
const content::LoadCommittedDetails& details,
const content::FrameNavigateParams& params) {
- if (form_to_save_)
- form_to_save_->ApplyChange();
if (!details.is_in_page) {
// Clear "blocked" flags.
ClearBlockedContentSettingsExceptForCookies();

Powered by Google App Engine
This is Rietveld 408576698