Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2402313003: [turbofan] Quit storing strings in types. (Closed)

Created:
4 years, 2 months ago by mvstanton
Modified:
4 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Quit storing strings in types. BUG= Committed: https://crrev.com/1bf1c5303d9a53740f54735eed3eee6dd367a81d Cr-Commit-Position: refs/heads/master@{#40245}

Patch Set 1 #

Patch Set 2 : Improvements. #

Patch Set 3 : improve typeof. #

Patch Set 4 : REBASE. #

Patch Set 5 : Removed StringFromCharCodeTyper optimization. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -19 lines) Patch
M src/compiler/typer.cc View 1 2 3 4 1 chunk +0 lines, -18 lines 0 comments Download
M src/compiler/types.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M test/unittests/compiler/graph-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
mvstanton
Hi Benedikt, Here is the CL we discussed. As mentioned offline, ShouldCreateConsString() will always return ...
4 years, 2 months ago (2016-10-10 15:18:40 UTC) #4
mvstanton
Hi Benedikt, Now I removed the StringFromCharCodeTyper optimization that creates a string type with embedded ...
4 years, 2 months ago (2016-10-12 13:01:13 UTC) #7
Benedikt Meurer
lgtm
4 years, 2 months ago (2016-10-13 03:43:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2402313003/80001
4 years, 2 months ago (2016-10-13 07:23:35 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 2 months ago (2016-10-13 07:26:33 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 07:26:50 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/1bf1c5303d9a53740f54735eed3eee6dd367a81d
Cr-Commit-Position: refs/heads/master@{#40245}

Powered by Google App Engine
This is Rietveld 408576698