Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: src/compiler/typer.cc

Issue 2402313003: [turbofan] Quit storing strings in types. (Closed)
Patch Set: Removed StringFromCharCodeTyper optimization. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/types.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/typer.cc
diff --git a/src/compiler/typer.cc b/src/compiler/typer.cc
index fe6507fb162e07cb8ed71dfcf01ad2275037a6ae..1431ff769ec6d5eaa42c93dc46e60b0d122a5457 100644
--- a/src/compiler/typer.cc
+++ b/src/compiler/typer.cc
@@ -1527,28 +1527,10 @@ Type* Typer::Visitor::TypeStringLessThanOrEqual(Node* node) {
}
Type* Typer::Visitor::StringFromCharCodeTyper(Type* type, Typer* t) {
- type = NumberToUint32(ToNumber(type, t), t);
- Factory* f = t->isolate()->factory();
- double min = type->Min();
- double max = type->Max();
- if (min == max) {
- uint32_t code = static_cast<uint32_t>(min) & String::kMaxUtf16CodeUnitU;
- Handle<String> string = f->LookupSingleCharacterStringFromCode(code);
- return Type::HeapConstant(string, t->zone());
- }
return Type::String();
}
Type* Typer::Visitor::StringFromCodePointTyper(Type* type, Typer* t) {
- type = NumberToUint32(ToNumber(type, t), t);
- Factory* f = t->isolate()->factory();
- double min = type->Min();
- double max = type->Max();
- if (min == max) {
- uint32_t code = static_cast<uint32_t>(min) & String::kMaxUtf16CodeUnitU;
- Handle<String> string = f->LookupSingleCharacterStringFromCode(code);
- return Type::HeapConstant(string, t->zone());
- }
return Type::String();
}
« no previous file with comments | « no previous file | src/compiler/types.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698