Chromium Code Reviews| Index: Source/core/rendering/RenderText.cpp |
| diff --git a/Source/core/rendering/RenderText.cpp b/Source/core/rendering/RenderText.cpp |
| index 6e1703a0a230f11e817ba55611458abdc7956828..69fdfab46a9f1a7140d7d5705f52568f51778052 100644 |
| --- a/Source/core/rendering/RenderText.cpp |
| +++ b/Source/core/rendering/RenderText.cpp |
| @@ -330,10 +330,10 @@ static FloatRect localQuadForTextBox(InlineTextBox* box, unsigned start, unsigne |
| // Change the height and y position (or width and x for vertical text) |
| // because selectionRect uses selection-specific values. |
| if (box->isHorizontal()) { |
| - r.setHeight(box->logicalHeight()); |
| + r.setHeight(box->height()); |
|
eae
2013/09/24 23:14:25
How about removing the branching on isHorizontal a
Xianzhu
2013/09/24 23:16:43
No, we still need the branches for r.setHeight/Y a
eae
2013/09/24 23:19:30
Right, r is a LayoutRect which isn't direction awa
|
| r.setY(box->y()); |
| } else { |
| - r.setWidth(box->logicalWidth()); |
| + r.setWidth(box->width()); |
| r.setX(box->x()); |
| } |
| } |