Fix wrong width of Range in vertical text

Source/core/rendering/RenderText.cpp

 /*
  * (C) 1999 Lars Knoll (knoll@kde.org)
  * (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Andrew Wellington (proton@wiretapped.net)
  * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 312 matching lines @@
 
 static FloatRect localQuadForTextBox(InlineTextBox* box, unsigned start, unsigned end, bool useSelectionHeight)
 {
     unsigned realEnd = min(box->end() + 1, end);
     LayoutRect r = box->localSelectionRect(start, realEnd);
     if (r.height()) {
         if (!useSelectionHeight) {
             // Change the height and y position (or width and x for vertical text)
             // because selectionRect uses selection-specific values.
             if (box->isHorizontal()) {
-                r.setHeight(box->logicalHeight());
+                r.setHeight(box->height());

[eae, 2013/09/24 23:14:25]

How about removing the branching on isHorizontal and changing the code to use
the logical left/width methods instead?

r.setX(box->logicalLeft());
r.setHeight(box->logicalHeight());

[Xianzhu, 2013/09/24 23:16:43]

No, we still need the branches for r.setHeight/Y and r.setWidth/X.

[eae, 2013/09/24 23:19:30]

Right, r is a LayoutRect which isn't direction aware (yet!).

                 r.setY(box->y());
             } else {
-                r.setWidth(box->logicalWidth());
+                r.setWidth(box->width());
                 r.setX(box->x());
             }
         }
         return FloatRect(r);
     }
     return FloatRect();
 }
 
 void RenderText::absoluteRectsForRange(Vector<IntRect>& rects, unsigned start, unsigned end, bool useSelectionHeight, bool* wasFixed)
 {
@@ skipping 1510 matching lines @@
 
     SecureTextTimer* secureTextTimer = gSecureTextTimers->get(this);
     if (!secureTextTimer) {
         secureTextTimer = new SecureTextTimer(this);
         gSecureTextTimers->add(this, secureTextTimer);
     }
     secureTextTimer->restartWithNewText(lastTypedCharacterOffset);
 }
 
 } // namespace WebCore