Fix class name which has only space

Fix class name which has only space

When length of className is 0, should return ClassStringContent::Empty, this is done by classStringHasClassName(const AtomicString& newClassString. If length >= 1 and only white space, should return ClassStringContent::WhiteSpaceOnly.
Spec is here: https://dom.spec.whatwg.org/#dom-element-classname.
This is from w3c-test: http://w3c-test.org/dom/nodes/Element-classlist.html.

BUG=651744
Test=LayoutTests/imported/wpt/dom/nodes/Element-classlist.html

Committed: https://crrev.com/26b5369d478f5ef43d45ca0c7db8e48dadac35c9
Cr-Commit-Position: refs/heads/master@{#425578}

[xing.xu, 2016-10-09 08:45:16]

Description was changed from

==========
Fix class name which has only space

Spec is here: https://dom.spec.whatwg.org/#dom-element-classname
BUG=651744

Test=LayoutTests/imported/wpt/dom/nodes/Element-classlist.html
==========

to

==========
Fix class name which has only space

Spec is here: https://dom.spec.whatwg.org/#dom-element-classname
BUG=651744

Test=LayoutTests/imported/wpt/dom/nodes/Element-classlist.html
==========

[xing.xu, 2016-10-09 08:45:16]

xing.xu@intel.com changed reviewers:
+ foolip@chromium.org, skobes@chromium.org

[xing.xu, 2016-10-09 08:45:52]

Hi, please help to review.

[xing.xu, 2016-10-09 08:46:31]

Description was changed from

==========
Fix class name which has only space

Spec is here: https://dom.spec.whatwg.org/#dom-element-classname
BUG=651744

Test=LayoutTests/imported/wpt/dom/nodes/Element-classlist.html
==========

to

==========
Fix class name which has only space

Spec is here: https://dom.spec.whatwg.org/#dom-element-classname.
This is from w3c-test: http://w3c-test.org/dom/nodes/Element-classlist.html
BUG=651744

Test=LayoutTests/imported/wpt/dom/nodes/Element-classlist.html
==========

[xing.xu, 2016-10-09 08:46:50]

Description was changed from

==========
Fix class name which has only space

Spec is here: https://dom.spec.whatwg.org/#dom-element-classname.
This is from w3c-test: http://w3c-test.org/dom/nodes/Element-classlist.html
BUG=651744

Test=LayoutTests/imported/wpt/dom/nodes/Element-classlist.html
==========

to

==========
Fix class name which has only space

Spec is here: https://dom.spec.whatwg.org/#dom-element-classname.
This is from w3c-test: http://w3c-test.org/dom/nodes/Element-classlist.html.

BUG=651744

Test=LayoutTests/imported/wpt/dom/nodes/Element-classlist.html
==========

[foolip, 2016-10-10 11:58:09]

The CQ bit was checked by foolip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 11:58:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[foolip, 2016-10-10 11:58:30]

On 2016/10/09 08:45:52, xing.xu wrote:
> Hi, please help to review.

Started a dry run, I'm guessing some existing tests will fail.

[commit-bot: I haz the power, 2016-10-10 13:35:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 13:35:22]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[xing.xu, 2016-10-11 01:58:56]

On 2016/10/10 11:58:30, foolip wrote:
> On 2016/10/09 08:45:52, xing.xu wrote:
> > Hi, please help to review.
> 
> Started a dry run, I'm guessing some existing tests will fail.

Thanks, I will keep investigating it.

The failed cases:
linux_chromium_rel_ng
unexpected_failures:
paint/invalidation/transform-rotate-and-remove.html
paint/invalidation/scrolled-iframe-scrollbar-change.html
paint/invalidation/do-not-paint-below-image-baseline.html

mac_chromium_rel_ng
unexpected_failures:
paint/invalidation/transform-rotate-and-remove.html
paint/invalidation/scrolled-iframe-scrollbar-change.html
paint/invalidation/do-not-paint-below-image-baseline.html

win_chromium_rel_ng
unexpected_failures:
fast/text/font-weight.html
fast/text/textIteratorNilRenderer.html
paint/invalidation/scrolled-iframe-scrollbar-change.html
fast/text/font-stretch-variant.html
paint/invalidation/do-not-paint-below-image-baseline.html
fast/text/sub-pixel/text-scaling-pixel.html
fast/text/international/bidi-listbox.html
fast/text/international/bidi-listbox-atsui.html
fast/text/international/lang-glyph-cache-separation.html
fast/text/font-stretch.html
fast/text/drawBidiText.html
paint/invalidation/transform-rotate-and-remove.html
fast/text/font-features/caps-native-synthesis.html

[xing.xu, 2016-10-14 02:51:50]

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 02:52:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 04:20:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 04:20:48]

Dry run: This issue passed the CQ dry run.

[xing.xu, 2016-10-14 04:47:03]

Hi, foolip@,skobes@, fix the tests, PTAL.

[skobes, 2016-10-14 20:41:31]

https://codereview.chromium.org/2402223002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/paint/invalidation/transform-rotate-and-remove-expected.txt
(right):

https://codereview.chromium.org/2402223002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/paint/invalidation/transform-rotate-and-remove-expected.txt:10:
"object": "LayoutBlockFlow DIV id='rel' class=''",
The w3c test is for a class name containing space " " but here it looks like the
patch also changed treatment of the empty string "".  Is that intended?

https://codereview.chromium.org/2402223002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Element.cpp (right):

https://codereview.chromium.org/2402223002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Element.cpp:1380:
elementData()->setClass(newClassString, shouldFoldCase);
I don't quite understand how this works.  Setting class=" " seems like it should
produce classStringContentType == WhiteSpaceOnly, but this only changes the
logic for classStringContentType == Empty?

[xing.xu, 2016-10-14 23:10:25]

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 23:10:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-15 01:04:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-15 01:04:20]

Dry run: This issue passed the CQ dry run.

[xing.xu, 2016-10-15 05:34:48]

On 2016/10/14 20:41:31, skobes wrote:
>
https://codereview.chromium.org/2402223002/diff/20001/third_party/WebKit/Layo...
> File
>
third_party/WebKit/LayoutTests/paint/invalidation/transform-rotate-and-remove-expected.txt
> (right):
> 
>
https://codereview.chromium.org/2402223002/diff/20001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/paint/invalidation/transform-rotate-and-remove-expected.txt:10:
> "object": "LayoutBlockFlow DIV id='rel' class=''",
> The w3c test is for a class name containing space " " but here it looks like
the
> patch also changed treatment of the empty string "".  Is that intended?
> 
>
https://codereview.chromium.org/2402223002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/dom/Element.cpp (right):
> 
>
https://codereview.chromium.org/2402223002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/dom/Element.cpp:1380:
> elementData()->setClass(newClassString, shouldFoldCase);
> I don't quite understand how this works.  Setting class=" " seems like it
should
> produce classStringContentType == WhiteSpaceOnly, but this only changes the
> logic for classStringContentType == Empty?

The previous patch is overdone, we need to handle Empty and WhiteSpaceOnly
separately.  Refined in my new patch,PTAL.

[xing.xu, 2016-10-15 06:04:42]

Description was changed from

==========
Fix class name which has only space

Spec is here: https://dom.spec.whatwg.org/#dom-element-classname.
This is from w3c-test: http://w3c-test.org/dom/nodes/Element-classlist.html.

BUG=651744

Test=LayoutTests/imported/wpt/dom/nodes/Element-classlist.html
==========

to

==========
Fix class name which has only space

When length of className is 0, should return ClassStringContent::Empty, this is
done by classStringHasClassName(const AtomicString& newClassString. If length >=
1 and only white space, should return ClassStringContent::WhiteSpaceOnly.
Spec is here: https://dom.spec.whatwg.org/#dom-element-classname.
This is from w3c-test: http://w3c-test.org/dom/nodes/Element-classlist.html.

BUG=651744

Test=LayoutTests/imported/wpt/dom/nodes/Element-classlist.html
==========

[skobes, 2016-10-15 19:12:11]

lgtm

[xing.xu, 2016-10-15 23:09:18]

The CQ bit was checked by xing.xu@intel.com

[commit-bot: I haz the power, 2016-10-15 23:09:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xing.xu, 2016-10-15 23:09:45]

The CQ bit was unchecked by xing.xu@intel.com

[xing.xu, 2016-10-15 23:16:15]

The CQ bit was checked by xing.xu@intel.com

[commit-bot: I haz the power, 2016-10-15 23:16:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-15 23:21:55]

Description was changed from

==========
Fix class name which has only space

When length of className is 0, should return ClassStringContent::Empty, this is
done by classStringHasClassName(const AtomicString& newClassString. If length >=
1 and only white space, should return ClassStringContent::WhiteSpaceOnly.
Spec is here: https://dom.spec.whatwg.org/#dom-element-classname.
This is from w3c-test: http://w3c-test.org/dom/nodes/Element-classlist.html.

BUG=651744

Test=LayoutTests/imported/wpt/dom/nodes/Element-classlist.html
==========

to

==========
Fix class name which has only space

When length of className is 0, should return ClassStringContent::Empty, this is
done by classStringHasClassName(const AtomicString& newClassString. If length >=
1 and only white space, should return ClassStringContent::WhiteSpaceOnly.
Spec is here: https://dom.spec.whatwg.org/#dom-element-classname.
This is from w3c-test: http://w3c-test.org/dom/nodes/Element-classlist.html.

BUG=651744

Test=LayoutTests/imported/wpt/dom/nodes/Element-classlist.html
==========

[commit-bot: I haz the power, 2016-10-15 23:21:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-15 23:23:26]

Description was changed from

==========
Fix class name which has only space

When length of className is 0, should return ClassStringContent::Empty, this is
done by classStringHasClassName(const AtomicString& newClassString. If length >=
1 and only white space, should return ClassStringContent::WhiteSpaceOnly.
Spec is here: https://dom.spec.whatwg.org/#dom-element-classname.
This is from w3c-test: http://w3c-test.org/dom/nodes/Element-classlist.html.

BUG=651744

Test=LayoutTests/imported/wpt/dom/nodes/Element-classlist.html
==========

to

==========
Fix class name which has only space

When length of className is 0, should return ClassStringContent::Empty, this is
done by classStringHasClassName(const AtomicString& newClassString. If length >=
1 and only white space, should return ClassStringContent::WhiteSpaceOnly.
Spec is here: https://dom.spec.whatwg.org/#dom-element-classname.
This is from w3c-test: http://w3c-test.org/dom/nodes/Element-classlist.html.

BUG=651744

Test=LayoutTests/imported/wpt/dom/nodes/Element-classlist.html

Committed: https://crrev.com/26b5369d478f5ef43d45ca0c7db8e48dadac35c9
Cr-Commit-Position: refs/heads/master@{#425578}
==========

[commit-bot: I haz the power, 2016-10-15 23:23:27]

Patchset 3 (id:??) landed as
https://crrev.com/26b5369d478f5ef43d45ca0c7db8e48dadac35c9
Cr-Commit-Position: refs/heads/master@{#425578}