Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 2402133002: Field should not be initialized until after initializer returns (Closed)

Created:
4 years, 2 months ago by hausner
Modified:
4 years, 2 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Lasse Reichstein Nielsen
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Field should not be initialized until after initializer returns A field with an initializer expression is uninitialized until the expression is fully evaluated. If the initializer expression reads the field multiple times, a circular reference error must be thrown for each time the field is read. BUG=#27466 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/d643234264c541955e3aec6e9157916e8e47270e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M runtime/vm/object.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
hausner
4 years, 2 months ago (2016-10-07 23:10:33 UTC) #3
Florian Schneider
Lgtm
4 years, 2 months ago (2016-10-07 23:13:41 UTC) #4
hausner
4 years, 2 months ago (2016-10-07 23:31:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d643234264c541955e3aec6e9157916e8e47270e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698