runtime/vm/object.cc - Issue 2402133002: Field should not be initialized until after initializer returns

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 2402133002: Field should not be initialized until after initializer returns (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/object.cc

diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc

index 6f0f16472e248b3bddd20d37e062b2055ceaa405..ea4c3cab31bec39a898e20cba39191ab5a023182 100644

--- a/runtime/vm/object.cc

+++ b/runtime/vm/object.cc

@@ -7876,7 +7876,6 @@ void Field::EvaluateInitializer() const {

: Instance::Cast(value));

return;

} else if (StaticValue() == Object::transition_sentinel().raw()) {

- SetStaticValue(Object::null_instance());

const Array& ctor_args = Array::Handle(Array::New(1));

const String& field_name = String::Handle(name());

ctor_args.SetAt(0, field_name);

« no previous file with comments | « no previous file | no next file » | no next file with comments »