chrome/browser/value_store/value_store_frontend_unittest.cc - Issue 24021002: Propagate more information about ValueStore errors to callers, notably an

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/value_store/value_store_frontend_unittest.cc

Issue 24021002: Propagate more information about ValueStore errors to callers, notably an (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/value_store/leveldb_value_store.cc ('K') | « chrome/browser/value_store/value_store_frontend.cc ('k') | chrome/browser/value_store/value_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/value_store/value_store_frontend_unittest.cc

diff --git a/chrome/browser/value_store/value_store_frontend_unittest.cc b/chrome/browser/value_store/value_store_frontend_unittest.cc

index 2eab715f1dbbf87ce93d8f727883660dd5bc9d39..f676be76d999812dd60064357226819accc97e82 100644

--- a/chrome/browser/value_store/value_store_frontend_unittest.cc

+++ b/chrome/browser/value_store/value_store_frontend_unittest.cc

@@ -14,8 +14,6 @@

using content::BrowserThread;

-// Test suite for CachingValueStore, using a test database with a few simple

-// entries.

class ValueStoreFrontendTest : public testing::Test {

public:

ValueStoreFrontendTest()

@@ -95,7 +93,7 @@ TEST_F(ValueStoreFrontendTest, ChangesPersistAfterReload) {

storage_->Remove("key2");

// Reload the DB and test our changes.

- ResetStorage();

+ //ResetStorage();

Matt Perry 2013/09/06 20:07:30 ?

not at google - send to devlin 2013/09/06 21:44:28 oh oops. Fixed.

scoped_ptr<base::Value> value;

{