Propagate more information about ValueStore errors to callers, notably an

chrome/browser/value_store/value_store_frontend_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/path_service.h"
 #include "chrome/browser/value_store/value_store_frontend.h"
 #include "chrome/common/chrome_paths.h"
 #include "content/public/test/test_browser_thread.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using content::BrowserThread;
 
-// Test suite for CachingValueStore, using a test database with a few simple
-// entries.
 class ValueStoreFrontendTest : public testing::Test {
  public:
   ValueStoreFrontendTest()
       : ui_thread_(BrowserThread::UI, base::MessageLoop::current()),
         file_thread_(BrowserThread::FILE, base::MessageLoop::current()) {
   }
 
   virtual void SetUp() {
     ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
 
@@ skipping 59 matching lines @@
 }
 
 TEST_F(ValueStoreFrontendTest, ChangesPersistAfterReload) {
   storage_->Set("key0",
       scoped_ptr<base::Value>(base::Value::CreateIntegerValue(0)));
   storage_->Set("key1",
       scoped_ptr<base::Value>(base::Value::CreateStringValue("new1")));
   storage_->Remove("key2");
 
   // Reload the DB and test our changes.
-  ResetStorage();
+  //ResetStorage();

[Matt Perry, 2013/09/06 20:07:30]

?

[not at google - send to devlin, 2013/09/06 21:44:28]

oh oops. Fixed.

 
   scoped_ptr<base::Value> value;
   {
     ASSERT_TRUE(Get("key0", &value));
     int result;
     ASSERT_TRUE(value->GetAsInteger(&result));
     EXPECT_EQ(0, result);
   }
 
   {
     ASSERT_TRUE(Get("key1", &value));
     std::string result;
     ASSERT_TRUE(value->GetAsString(&result));
     EXPECT_EQ("new1", result);
   }
 
   ASSERT_FALSE(Get("key2", &value));
 }