Move GetRootWindowController() to root_window_controller.h

Move GetRootWindowController to root_window_controller.h
Remove unnecessary includes, forward decls

BUG=272460
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221605

[Daniel Erat, 2013-09-06 01:00:35]

lgtm

https://codereview.chromium.org/24020002/diff/2001/ash/root_window_controller.cc
File ash/root_window_controller.cc (right):

https://codereview.chromium.org/24020002/diff/2001/ash/root_window_controller...
ash/root_window_controller.cc:822: return root_window ?
GetRootWindowSettings(root_window)->controller : NULL;
is it valid to pass a NULL root window, or would it make more sense to add a
DCHECK() here?

https://codereview.chromium.org/24020002/diff/2001/ash/wm/gestures/long_press...
File ash/wm/gestures/long_press_affordance_handler.cc (right):

https://codereview.chromium.org/24020002/diff/2001/ash/wm/gestures/long_press...
ash/wm/gestures/long_press_affordance_handler.cc:71:
ash::internal::GetRootWindowController(root_window)->GetContainer(
nit: any reason not to move this anon namespace into ash::internal so you don't
need these qualifiers?

[oshima, 2013-09-06 01:11:06]

https://codereview.chromium.org/24020002/diff/2001/ash/root_window_controller.cc
File ash/root_window_controller.cc (right):

https://codereview.chromium.org/24020002/diff/2001/ash/root_window_controller...
ash/root_window_controller.cc:822: return root_window ?
GetRootWindowSettings(root_window)->controller : NULL;
On 2013/09/06 01:00:35, Daniel Erat wrote:
> is it valid to pass a NULL root window, or would it make more sense to add a
> DCHECK() here?
It is valid. This is to avoid boiler plate code like

if (window->GetRootWindow()) {
  RootWindowController* controller =
GetRootWindowCotnroller(window->GetRootWindow());
  if (controller) {
     Do something root window controller
  }
}

https://codereview.chromium.org/24020002/diff/2001/ash/wm/gestures/long_press...
File ash/wm/gestures/long_press_affordance_handler.cc (right):

https://codereview.chromium.org/24020002/diff/2001/ash/wm/gestures/long_press...
ash/wm/gestures/long_press_affordance_handler.cc:71:
ash::internal::GetRootWindowController(root_window)->GetContainer(
On 2013/09/06 01:00:35, Daniel Erat wrote:
> nit: any reason not to move this anon namespace into ash::internal so you
don't
> need these qualifiers?

Agreed. done.

[commit-bot: I haz the power, 2013-09-06 02:44:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/24020002/9001

[commit-bot: I haz the power, 2013-09-06 06:29:56]

Change committed as 221605