Remount all removable storage devices upon policy update

Remount all removable storage devices when received update of
ExternalStorageReadOnly policy.

The end-to-end test can be done manually in this way:
1. Enter public session mode.
   See https://support.google.com/chrome/a/answer/3017014?hl=en
2. Plug a removable storage / MTP device.
3. Change the policy in Google admin and make sure it is reloaded at chrome://policy.
4. Check if the device is mounted RO/RW accordingly by right-clicking it in Files app. When the device is read-only, it the "format drive" menu will be grayed out.

This change depends on
https://chromium-review.googlesource.com/#/c/390410/
in chromeos. (which is already merged to trunk)

BUG=642247
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TEST=manual test as described above

Committed: https://crrev.com/28bce536b995429341b58d5bb6a826228bb6ef15
Cr-Commit-Position: refs/heads/master@{#431206}

[yamaguchi, 2016-10-07 16:03:31]

Description was changed from

==========
Remount all removable storage devices when received update of
ExternalStorageReadOnly policy.

WIP.

BUG=642247
==========

to

==========
Remount all removable storage devices when received update of
ExternalStorageReadOnly policy.

WIP.

BUG=642247
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yamaguchi, 2016-10-19 05:16:04]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 05:17:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 10:50:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 10:50:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yamaguchi, 2016-10-25 03:19:26]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 03:19:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 04:16:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 04:16:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yamaguchi, 2016-10-25 04:56:34]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 04:56:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2016-11-08 12:18:36]

Description was changed from

==========
Remount all removable storage devices when received update of
ExternalStorageReadOnly policy.

WIP.

BUG=642247
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Remount all removable storage devices when received update of
ExternalStorageReadOnly policy.

BUG=642247
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yamaguchi, 2016-11-08 12:18:45]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 12:19:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 14:46:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 14:46:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yamaguchi, 2016-11-09 09:02:26]

Description was changed from

==========
Remount all removable storage devices when received update of
ExternalStorageReadOnly policy.

BUG=642247
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Remount all removable storage devices when received update of
ExternalStorageReadOnly policy.

The end-to-end test can be done manually in this way:
1. Enter public session mode.
   See https://support.google.com/chrome/a/answer/3017014?hl=en
2. Plug a removable storage / MTP device.
3. Change the policy in Google admin and make sure it is reloaded at
chrome://policy. 
4. Check if the device is mounted RO/RW accordingly by right-clicking it in
Files app. When the device is read-only, it the "format drive" menu will be
grayed out.

BUG=642247
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TEST=manual test as described above
==========

[yamaguchi, 2016-11-09 09:03:04]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 09:03:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2016-11-09 09:43:40]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 09:43:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2016-11-09 10:10:27]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 10:10:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2016-11-09 10:25:35]

Description was changed from

==========
Remount all removable storage devices when received update of
ExternalStorageReadOnly policy.

The end-to-end test can be done manually in this way:
1. Enter public session mode.
   See https://support.google.com/chrome/a/answer/3017014?hl=en
2. Plug a removable storage / MTP device.
3. Change the policy in Google admin and make sure it is reloaded at
chrome://policy. 
4. Check if the device is mounted RO/RW accordingly by right-clicking it in
Files app. When the device is read-only, it the "format drive" menu will be
grayed out.

BUG=642247
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TEST=manual test as described above
==========

to

==========
Remount all removable storage devices when received update of
ExternalStorageReadOnly policy.

The end-to-end test can be done manually in this way:
1. Enter public session mode.
   See https://support.google.com/chrome/a/answer/3017014?hl=en
2. Plug a removable storage / MTP device.
3. Change the policy in Google admin and make sure it is reloaded at
chrome://policy. 
4. Check if the device is mounted RO/RW accordingly by right-clicking it in
Files app. When the device is read-only, it the "format drive" menu will be
grayed out.

This change depends on
https://chromium-review.googlesource.com/#/c/390410/
in chromeos. (which is already merged to trunk)

BUG=642247
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TEST=manual test as described above
==========

[commit-bot: I haz the power, 2016-11-09 10:39:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 10:39:31]

Dry run: This issue passed the CQ dry run.

[yamaguchi, 2016-11-09 11:46:05]

yamaguchi@chromium.org changed reviewers:
+ fukino@chromium.org

[yamaguchi, 2016-11-09 11:46:46]

yamaguchi@chromium.org changed reviewers:
- fukino@chromium.org

[yamaguchi, 2016-11-10 02:13:11]

yamaguchi@chromium.org changed reviewers:
+ fukino@chromium.org

[yamaguchi, 2016-11-10 02:13:12]

ptal

[yamaguchi, 2016-11-10 05:37:32]

yamaguchi@chromium.org changed reviewers:
+ hirono@chromium.org
- fukino@chromium.org

[hirono, 2016-11-10 07:12:24]

lgtm with a nit!

https://codereview.chromium.org/2401963002/diff/230001/chrome/browser/chromeo...
File chrome/browser/chromeos/file_manager/volume_manager_unittest.cc (right):

https://codereview.chromium.org/2401963002/diff/230001/chrome/browser/chromeo...
chrome/browser/chromeos/file_manager/volume_manager_unittest.cc:798:
EXPECT_EQ(2U, disk_mount_manager_->remount_all_requests().size());
nit: Should be ASSERT_EQ, because the test will crash at #800 if the size is
zero.

[yamaguchi, 2016-11-10 07:22:22]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 07:22:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 07:48:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 07:48:58]

Dry run: This issue passed the CQ dry run.

[yamaguchi, 2016-11-10 07:54:41]

The CQ bit was checked by yamaguchi@chromium.org

[yamaguchi, 2016-11-10 07:54:41]

The patchset sent to the CQ was uploaded after l-g-t-m from hirono@chromium.org
Link to the patchset: https://codereview.chromium.org/2401963002/#ps250001
(title: "User ASSERT_EQ to avoid test crash.")

[commit-bot: I haz the power, 2016-11-10 07:54:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 07:59:37]

Description was changed from

==========
Remount all removable storage devices when received update of
ExternalStorageReadOnly policy.

The end-to-end test can be done manually in this way:
1. Enter public session mode.
   See https://support.google.com/chrome/a/answer/3017014?hl=en
2. Plug a removable storage / MTP device.
3. Change the policy in Google admin and make sure it is reloaded at
chrome://policy. 
4. Check if the device is mounted RO/RW accordingly by right-clicking it in
Files app. When the device is read-only, it the "format drive" menu will be
grayed out.

This change depends on
https://chromium-review.googlesource.com/#/c/390410/
in chromeos. (which is already merged to trunk)

BUG=642247
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TEST=manual test as described above
==========

to

==========
Remount all removable storage devices when received update of
ExternalStorageReadOnly policy.

The end-to-end test can be done manually in this way:
1. Enter public session mode.
   See https://support.google.com/chrome/a/answer/3017014?hl=en
2. Plug a removable storage / MTP device.
3. Change the policy in Google admin and make sure it is reloaded at
chrome://policy. 
4. Check if the device is mounted RO/RW accordingly by right-clicking it in
Files app. When the device is read-only, it the "format drive" menu will be
grayed out.

This change depends on
https://chromium-review.googlesource.com/#/c/390410/
in chromeos. (which is already merged to trunk)

BUG=642247
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TEST=manual test as described above
==========

[commit-bot: I haz the power, 2016-11-10 07:59:41]

Committed patchset #14 (id:250001)

[commit-bot: I haz the power, 2016-11-10 08:03:41]

Description was changed from

==========
Remount all removable storage devices when received update of
ExternalStorageReadOnly policy.

The end-to-end test can be done manually in this way:
1. Enter public session mode.
   See https://support.google.com/chrome/a/answer/3017014?hl=en
2. Plug a removable storage / MTP device.
3. Change the policy in Google admin and make sure it is reloaded at
chrome://policy. 
4. Check if the device is mounted RO/RW accordingly by right-clicking it in
Files app. When the device is read-only, it the "format drive" menu will be
grayed out.

This change depends on
https://chromium-review.googlesource.com/#/c/390410/
in chromeos. (which is already merged to trunk)

BUG=642247
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TEST=manual test as described above
==========

to

==========
Remount all removable storage devices when received update of
ExternalStorageReadOnly policy.

The end-to-end test can be done manually in this way:
1. Enter public session mode.
   See https://support.google.com/chrome/a/answer/3017014?hl=en
2. Plug a removable storage / MTP device.
3. Change the policy in Google admin and make sure it is reloaded at
chrome://policy.
4. Check if the device is mounted RO/RW accordingly by right-clicking it in
Files app. When the device is read-only, it the "format drive" menu will be
grayed out.

This change depends on
https://chromium-review.googlesource.com/#/c/390410/
in chromeos. (which is already merged to trunk)

BUG=642247
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TEST=manual test as described above

Committed: https://crrev.com/28bce536b995429341b58d5bb6a826228bb6ef15
Cr-Commit-Position: refs/heads/master@{#431206}
==========

[commit-bot: I haz the power, 2016-11-10 08:03:43]

Patchset 14 (id:??) landed as
https://crrev.com/28bce536b995429341b58d5bb6a826228bb6ef15
Cr-Commit-Position: refs/heads/master@{#431206}

[yamaguchi, 2016-11-10 08:44:30]

https://codereview.chromium.org/2401963002/diff/230001/chrome/browser/chromeo...
File chrome/browser/chromeos/file_manager/volume_manager_unittest.cc (right):

https://codereview.chromium.org/2401963002/diff/230001/chrome/browser/chromeo...
chrome/browser/chromeos/file_manager/volume_manager_unittest.cc:798:
EXPECT_EQ(2U, disk_mount_manager_->remount_all_requests().size());
On 2016/11/10 07:12:24, hirono wrote:
> nit: Should be ASSERT_EQ, because the test will crash at #800 if the size is
> zero.

Done.