Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: chrome/browser/chromeos/file_manager/volume_manager_unittest.cc

Issue 2401963002: Remount all removable storage devices upon policy update (Closed)
Patch Set: User ASSERT_EQ to avoid test crash. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_manager/volume_manager_unittest.cc
diff --git a/chrome/browser/chromeos/file_manager/volume_manager_unittest.cc b/chrome/browser/chromeos/file_manager/volume_manager_unittest.cc
index af42bea65e01ab3d57c308ac97178358fdc81c41..bff1e080efd845a6f831f3de5de73cc6915eb2cf 100644
--- a/chrome/browser/chromeos/file_manager/volume_manager_unittest.cc
+++ b/chrome/browser/chromeos/file_manager/volume_manager_unittest.cc
@@ -787,6 +787,25 @@ TEST_F(VolumeManagerTest, ExternalStorageDisabledPolicyMultiProfile) {
secondary.volume_manager()->RemoveObserver(&secondary_observer);
}
+TEST_F(VolumeManagerTest, OnExternalStorageReadOnlyChanged) {
+ // Emulate updates of kExternalStorageReadOnly (change to true, then false).
+ profile()->GetPrefs()->SetBoolean(prefs::kExternalStorageReadOnly, true);
+ volume_manager()->OnExternalStorageReadOnlyChanged();
+ profile()->GetPrefs()->SetBoolean(prefs::kExternalStorageReadOnly, false);
+ volume_manager()->OnExternalStorageReadOnlyChanged();
+
+ // Verify that remount of removable disks is triggered for each update.
+ ASSERT_EQ(2U, disk_mount_manager_->remount_all_requests().size());
+ const FakeDiskMountManager::RemountAllRequest& remount_request1 =
+ disk_mount_manager_->remount_all_requests()[0];
+ EXPECT_EQ(chromeos::MOUNT_ACCESS_MODE_READ_ONLY,
+ remount_request1.access_mode);
+ const FakeDiskMountManager::RemountAllRequest& remount_request2 =
+ disk_mount_manager_->remount_all_requests()[1];
+ EXPECT_EQ(chromeos::MOUNT_ACCESS_MODE_READ_WRITE,
+ remount_request2.access_mode);
+}
+
TEST_F(VolumeManagerTest, GetVolumeList) {
volume_manager()->Initialize(); // Adds "Downloads"
std::vector<base::WeakPtr<Volume>> volume_list =

Powered by Google App Engine
This is Rietveld 408576698