Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issue 2401923002: Added dummy definition for CanPartialSwap() in VulkanRenderer class

Created:
4 years, 2 months ago by kumar.vikram
Modified:
4 years, 2 months ago
Reviewers:
a.suchit2
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added dummy definition for CanPartialSwap() in VulkanRenderer class The above mentioned function is a pure virtual in class DirectRenderer, also the VulkanRenderer class inherits the DirectRenderer class but doesn't implement the method, which was causing build errors. Added dummy definition for CanPartialSwap() in VulkanRenderer class to fix the issue. BUG=582558, 582564 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M cc/output/vulkan_renderer.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/output/vulkan_renderer.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
a.suchit2
4 years, 2 months ago (2016-10-10 10:52:24 UTC) #4
Please upload a single patch for all the build issues in vulkan.

peer review not looks good to me.

Powered by Google App Engine
This is Rietveld 408576698