Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2401883002: [test] Add missing js-test resource. (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
Reviewers:
caitp
CC:
v8-reviews_googlegroups.com, Igor Sheludko, Camillo Bruni
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Add missing js-test resource. The create.js file is loaded unconditionally in run.js, therefore we need to add it to resources, otherwise it fails on Android. TBR=caitp@igalia.com NOTRY=true Committed: https://crrev.com/c64288d9db7ae0737c4c7bd0ad1bb673ff35ae4c Cr-Commit-Position: refs/heads/master@{#40084}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M test/js-perf-test/JSTests.json View 1 chunk +3 lines, -2 lines 1 comment Download

Messages

Total messages: 12 (5 generated)
Michael Achenbach
TBR https://codereview.chromium.org/2401883002/diff/1/test/js-perf-test/JSTests.json File test/js-perf-test/JSTests.json (right): https://codereview.chromium.org/2401883002/diff/1/test/js-perf-test/JSTests.json#newcode172 test/js-perf-test/JSTests.json:172: {"name": "Entries"}, Should this measure Create as well? ...
4 years, 2 months ago (2016-10-07 11:18:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401883002/1
4 years, 2 months ago (2016-10-07 11:19:18 UTC) #5
caitp
On 2016/10/07 11:19:18, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 2 months ago (2016-10-07 11:22:55 UTC) #6
caitp
Hey Camillo, maybe we shouldn't keep ObjectTests.json upstream (my bad, didn't realize they were in ...
4 years, 2 months ago (2016-10-07 11:27:51 UTC) #7
Michael Achenbach
Was added here: https://codereview.chromium.org/2378613002 CC'ing authors. @cbruni: If this should measure something it needs to ...
4 years, 2 months ago (2016-10-07 11:28:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 12:27:49 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 12:28:08 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c64288d9db7ae0737c4c7bd0ad1bb673ff35ae4c
Cr-Commit-Position: refs/heads/master@{#40084}

Powered by Google App Engine
This is Rietveld 408576698