Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2378613002: [test] Add micro benchmark for Object.create (Closed)

Created:
4 years, 2 months ago by Camillo Bruni
Modified:
4 years, 2 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Add micro benchmark for Object.create BUG= Committed: https://crrev.com/24e29f28ba8d651162baf8f443e786fbd6fc1f81 Cr-Commit-Position: refs/heads/master@{#39807}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -3 lines) Patch
M test/js-perf-test/Object/ObjectTests.json View 1 chunk +4 lines, -2 lines 0 comments Download
A test/js-perf-test/Object/create.js View 1 chunk +70 lines, -0 lines 0 comments Download
M test/js-perf-test/Object/run.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Camillo Bruni
PTAL
4 years, 2 months ago (2016-09-28 07:37:59 UTC) #2
Igor Sheludko
lgtm
4 years, 2 months ago (2016-09-28 07:42:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378613002/1
4 years, 2 months ago (2016-09-28 07:48:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 08:14:09 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 08:14:33 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24e29f28ba8d651162baf8f443e786fbd6fc1f81
Cr-Commit-Position: refs/heads/master@{#39807}

Powered by Google App Engine
This is Rietveld 408576698