Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2401863003: Move synthetic gesture input to be aligned with BeginFrame. (Closed)

Created:
4 years, 2 months ago by dtapuska
Modified:
4 years, 2 months ago
Reviewers:
sadrul
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, James Su
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move synthetic gesture input to be aligned with BeginFrame. The timing of synthetic events seems almost random. It is best to align it with something that doesn't fluctuate. Android already rAF aligns its synthetic input so do this for aura and mac as well. Reland https://codereview.chromium.org/2372873003. It was reverted because of a regression that was fixed in https://codereview.chromium.org/2385333002 BUG=646369 TBR=sadrul@chromium.org Committed: https://crrev.com/7f7c8cc8b97dd0d5c9159d9e60c62efbc35e6b53 Cr-Commit-Position: refs/heads/master@{#424449}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -4 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.h View 3 chunks +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +13 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 3 chunks +10 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 3 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
dtapuska
4 years, 2 months ago (2016-10-07 19:13:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401863003/1
4 years, 2 months ago (2016-10-11 15:31:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 16:26:00 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 16:28:13 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f7c8cc8b97dd0d5c9159d9e60c62efbc35e6b53
Cr-Commit-Position: refs/heads/master@{#424449}

Powered by Google App Engine
This is Rietveld 408576698