Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Issue 2372873003: Move synthetic gesture input to be aligned with BeginFrame. (Closed)

Created:
4 years, 2 months ago by dtapuska
Modified:
4 years, 2 months ago
Reviewers:
sadrul
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, James Su
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move synthetic gesture input to be aligned with BeginFrame. The timing of synthetic events seems almost random. It is best to align it with something that doesn't fluctuate. Android already rAF aligns its synthetic input so do this for aura and mac as well. BUG=646369 Committed: https://crrev.com/5248d2a4cc2ac706f0404b6c6edf196f5b491539 Cr-Commit-Position: refs/heads/master@{#421528}

Patch Set 1 #

Patch Set 2 : Fix unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -6 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.h View 3 chunks +12 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 4 chunks +26 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 3 chunks +10 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 3 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
dtapuska
PTAL
4 years, 2 months ago (2016-09-27 17:15:07 UTC) #3
dtapuska
On 2016/09/27 17:15:07, dtapuska wrote: > PTAL ping
4 years, 2 months ago (2016-09-28 14:25:09 UTC) #11
sadrul
lgtm
4 years, 2 months ago (2016-09-28 15:15:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372873003/20001
4 years, 2 months ago (2016-09-28 15:35:31 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-28 15:53:16 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5248d2a4cc2ac706f0404b6c6edf196f5b491539 Cr-Commit-Position: refs/heads/master@{#421528}
4 years, 2 months ago (2016-09-28 15:58:23 UTC) #17
dtapuska
4 years, 2 months ago (2016-10-03 19:39:47 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2390813002/ by dtapuska@chromium.org.

The reason for reverting is: Appears RenderWidgetHostViewChildFrame ends up
calling a virtual during the constructor and this isn't getting called. This is
an existing bug.

But the change in this CL reveals this bug so reverting this change for now.

.

Powered by Google App Engine
This is Rietveld 408576698