Chromium Code Reviews Chromium Code Reviews
Issue 2401853005:
Adding client code for new Windows 10 First Run Experience (Closed)
| Index: chrome/browser/resources/welcome/win10/inline/combined.html |
| diff --git a/chrome/browser/resources/welcome/win10/inline/combined.html b/chrome/browser/resources/welcome/win10/inline/combined.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..5924af961bbdef1edded5d58c1fc63dd766482c0 |
| --- /dev/null |
| +++ b/chrome/browser/resources/welcome/win10/inline/combined.html |
| @@ -0,0 +1,71 @@ |
| +<!DOCTYPE html> |
| +<html> |
| +<head> |
| + <title>$i18n{headerText}</title> |
| + |
| + <link rel="import" href="chrome://resources/html/cr.html"> |
| + <link rel="import" href="chrome://resources/html/load_time_data.html"> |
| + <link rel="import" href="chrome://resources/html/polymer.html"> |
| + <link rel="import" href="chrome://resources/html/util.html"> |
| + <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.html"> |
| + <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.html"> |
|
michaelpg
2016/10/16 23:09:18
I recommend creating your own iconset by copying t
Patrick Monette
2016/10/19 23:46:59
The icons I need already exist in the cr-elments/i
|
| + <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.html"> |
| + |
| + <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css"> |
| + <link rel="stylesheet" href="chrome://welcome-win10/welcome.css"> |
|
michaelpg
2016/10/16 23:09:17
strongly recommend using root-absolute paths:
hre
Patrick Monette
2016/10/19 23:46:59
Done.
|
| + |
| + <script src="chrome://welcome-win10/welcome-win10.js"></script> |
|
michaelpg
2016/10/16 23:09:17
These are a lot of dependencies. It's better to en
Patrick Monette
2016/10/19 23:46:59
I consolidated the JS files so I think this is not
|
| + <script src="chrome://welcome-win10/default-browser.js"></script> |
| + <script src="chrome://welcome-win10/taskbar-pin.js"></script> |
| + <script src="chrome://welcome-win10/toggle-section.js"></script> |
| + <script src="chrome://welcome-win10/strings.js"></script> |
| +</head> |
| +<body> |
| + <div class="content"> |
| + <div class="header-logo"></div> |
| + <div class="heading">$i18n{headerText}</div> |
| + <div class="sections"> |
| + <div class="section section--expanded"> |
|
michaelpg
2016/10/16 23:09:17
I don't understand the -- scoping here. Classes ca
Patrick Monette
2016/10/19 23:46:59
Done.
|
| + <div class="section-heading section-heading--expandable"> |
| + <div class="section-heading-text">$i18n{defaultBrowserSubheaderText}</div> |
|
michaelpg
2016/10/16 23:09:17
80-col limit, throughout (excluding tags w/ URLs l
Patrick Monette
2016/10/19 23:46:59
Done.
|
| + <iron-icon class="section-heading-expand" icon="icons:expand-more"></iron-icon> |
| + </div> |
| + <ol class="section-steps"> |
| + <li><a href="#" id="set-default-button">$i18n{openSettingsText}</a></li> |
| + <li> |
| + <div id="section-steps--click-edge"></div> |
| + <div class="screenshot-image screenshot-image--visible" id="screenshot-image--default"> |
| + <div class="screenshot-html-overlay" id="screenshot-html-overlay--browser"> |
| + <div>$i18n{webBrowserLabel}</div> |
| + </div> |
| + <div class="screenshot-html-overlay" id="screenshot-html-overlay--edge"> |
| + <div>$i18n{microsoftEdgeLabel}</div> |
| + </div> |
| + </div> |
| + </li> |
| + <li id="section-steps--select-chrome"></li> |
| + </ol> |
| + </div> |
| + <div class="section"> |
| + <div class="section-heading section-heading--expandable"> |
| + <div class="section-heading-text">$i18n{pinSubheaderText}</div> |
| + <iron-icon class="section-heading-expand" icon="icons:expand-more"></iron-icon> |
| + </div> |
| + <ol class="section-steps"> |
| + <li id="section-steps--right-click"></li> |
| + <li> |
| + <div id="section-steps--pin-taskbar"></div> |
| + <div class="screenshot-image screenshot-image--visible" id="screenshot-image--taskbar"> |
| + <div class="screenshot-html-overlay" id="screenshot-html-overlay--taskbar"> |
| + <div>$i18n{pinToTaskbarLabel}</div> |
| + </div> |
| + <div class="screenshot-html-overlay" id="screenshot-html-overlay--icon"></div> |
| + </div> |
| + </li> |
| + </ol> |
| + </div> |
| + </div> |
| + <a href="#" class="button" id="continue-button">$i18n{continueText}</a> |
| + </div> |
| +</body> |
| +</html> |
