chrome/browser/resources/welcome/win10/inline/combined.html - Issue 2401853005: Adding client code for new Windows 10 First Run Experience

Side by Side Diff: chrome/browser/resources/welcome/win10/inline/combined.html

Issue 2401853005: Adding client code for new Windows 10 First Run Experience (Closed)

Patch Set: Second round Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/browser/resources/welcome/win10/default-browser.js ('K') | « chrome/browser/resources/welcome/win10/default-browser.js ('k') | chrome/browser/resources/welcome/win10/inline/combined.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>$i18n{headerText}</title>

	5

	6 <link rel="import" href="chrome://resources/html/cr.html">

	7 <link rel="import" href="chrome://resources/html/load_time_data.html">

	8 <link rel="import" href="chrome://resources/html/polymer.html">

	9 <link rel="import" href="chrome://resources/html/util.html">

	10 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.h tml">

	11 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons .html">
	michaelpg 2016/10/16 23:09:18 I recommend creating your own iconset by copying t I recommend creating your own iconset by copying the icons you need instead of importing 1,000 icons: https://www.chromium.org/developers/updating-webui-for-material-design/using-... Patrick Monette 2016/10/19 23:46:59 The icons I need already exist in the cr-elments/i Show quoted text On 2016/10/16 23:09:18, michaelpg wrote: > I recommend creating your own iconset by copying the icons you need instead of > importing 1,000 icons: > https://www.chromium.org/developers/updating-webui-for-material-design/using-... The icons I need already exist in the cr-elments/icons.html file so I used it. Let me know if you'd still prefer I create my own.
	12 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.ht ml">

	13

	14 <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css">

	15 <link rel="stylesheet" href="chrome://welcome-win10/welcome.css">
	michaelpg 2016/10/16 23:09:17 strongly recommend using root-absolute paths: hre strongly recommend using root-absolute paths: href="/welcome.css" so if the base "welcome-win10" name changes, we don't have to change everything Patrick Monette 2016/10/19 23:46:59 Done. Show quoted text On 2016/10/16 23:09:17, michaelpg wrote: > strongly recommend using root-absolute paths: > > href="/welcome.css" > > so if the base "welcome-win10" name changes, we don't have to change everything Done.
	16

	17 <script src="chrome://welcome-win10/welcome-win10.js"></script>
	michaelpg 2016/10/16 23:09:17 These are a lot of dependencies. It's better to en These are a lot of dependencies. It's better to enforce (and dedupe) script dependencies via HTML imports (and then we can just use HTML imports here and alphabetize them). Please: * create a corresponding HTML file for each script * in each HTML file, <script src=""> the corresponding JS file * in each HTML file, add <link rel="import"> to import the HTML file for any script that script depends on * replace these <script>s with <link rel="import"> and alphabetize Patrick Monette 2016/10/19 23:46:59 I consolidated the JS files so I think this is not Show quoted text On 2016/10/16 23:09:17, michaelpg wrote: > These are a lot of dependencies. It's better to enforce (and dedupe) script > dependencies via HTML imports (and then we can just use HTML imports here and > alphabetize them). Please: > > * create a corresponding HTML file for each script > * in each HTML file, <script src=""> the corresponding JS file > * in each HTML file, add <link rel="import"> to import the HTML file for any > script that script depends on > * replace these <script>s with <link rel="import"> and alphabetize I consolidated the JS files so I think this is not needed anymore.
	18 <script src="chrome://welcome-win10/default-browser.js"></script>

	19 <script src="chrome://welcome-win10/taskbar-pin.js"></script>

	20 <script src="chrome://welcome-win10/toggle-section.js"></script>

	21 <script src="chrome://welcome-win10/strings.js"></script>

	22 </head>

	23 <body>

	24 <div class="content">

	25 <div class="header-logo"></div>

	26 <div class="heading">$i18n{headerText}</div>

	27 <div class="sections">

	28 <div class="section section--expanded">
	michaelpg 2016/10/16 23:09:17 I don't understand the -- scoping here. Classes ca I don't understand the -- scoping here. Classes can and should stack: <div class="section expanded"> <div class="heading expandable"> // do something with visible expandable headings: document.querySelector('.expanded heading.expandable'); Patrick Monette 2016/10/19 23:46:59 Done. Show quoted text On 2016/10/16 23:09:17, michaelpg wrote: > I don't understand the -- scoping here. Classes can and should stack: > <div class="section expanded"> > <div class="heading expandable"> > > // do something with visible expandable headings: > document.querySelector('.expanded heading.expandable'); Done.
	29 <div class="section-heading section-heading--expandable">

	30 <div class="section-heading-text">$i18n{defaultBrowserSubheaderText}</ div>
	michaelpg 2016/10/16 23:09:17 80-col limit, throughout (excluding tags w/ URLs l 80-col limit, throughout (excluding tags w/ URLs like <link rel>) Patrick Monette 2016/10/19 23:46:59 Done. Show quoted text On 2016/10/16 23:09:17, michaelpg wrote: > 80-col limit, throughout (excluding tags w/ URLs like <link rel>) Done.
	31 <iron-icon class="section-heading-expand" icon="icons:expand-more"></i ron-icon>

	32 </div>

	33 <ol class="section-steps">

	34 <li><a href="#" id="set-default-button">$i18n{openSettingsText}</a></l i>

	35 <li>

	36 <div id="section-steps--click-edge"></div>

	37 <div class="screenshot-image screenshot-image--visible" id="screensh ot-image--default">

	38 <div class="screenshot-html-overlay" id="screenshot-html-overlay-- browser">

	39 <div>$i18n{webBrowserLabel}</div>

	40 </div>

	41 <div class="screenshot-html-overlay" id="screenshot-html-overlay-- edge">

	42 <div>$i18n{microsoftEdgeLabel}</div>

	43 </div>

	44 </div>

	45 </li>

	46 <li id="section-steps--select-chrome"></li>

	47 </ol>

	48 </div>

	49 <div class="section">

	50 <div class="section-heading section-heading--expandable">

	51 <div class="section-heading-text">$i18n{pinSubheaderText}</div>

	52 <iron-icon class="section-heading-expand" icon="icons:expand-more"></i ron-icon>

	53 </div>

	54 <ol class="section-steps">

	55 <li id="section-steps--right-click"></li>

	56 <li>

	57 <div id="section-steps--pin-taskbar"></div>

	58 <div class="screenshot-image screenshot-image--visible" id="screensh ot-image--taskbar">

	59 <div class="screenshot-html-overlay" id="screenshot-html-overlay-- taskbar">

	60 <div>$i18n{pinToTaskbarLabel}</div>

	61 </div>

	62 <div class="screenshot-html-overlay" id="screenshot-html-overlay-- icon"></div>

	63 </div>

	64 </li>

	65 </ol>

	66 </div>

	67 </div>

	68 <a href="#" class="button" id="continue-button">$i18n{continueText}</a>

	69 </div>

	70 </body>

	71 </html>

OLD	NEW