Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2401803002: Moves Shell::ShowShelf() to WmShell (Closed)

Created:
4 years, 2 months ago by sky
Modified:
4 years, 2 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves Shell::ShowShelf() to WmShell Same for RootWindowController and WmRootWindowController. I want to move TestSessionStateDelegate to ash/common, and it uses these. BUG=none TEST=covered by tests R=msw@chromium.org Committed: https://crrev.com/e9bc4e0245c9a1e570ed2cf8e12152b9122275f2 Cr-Commit-Position: refs/heads/master@{#423791}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -25 lines) Patch
M ash/common/shelf/wm_shelf.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/common/wm_root_window_controller.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/common/wm_root_window_controller.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M ash/common/wm_shell.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/common/wm_shell.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ash/root_window_controller.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/root_window_controller.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M ash/shell.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/shell.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M ash/test/test_session_state_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
sky
4 years, 2 months ago (2016-10-06 23:46:04 UTC) #1
msw
lgtm
4 years, 2 months ago (2016-10-07 01:06:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401803002/1
4 years, 2 months ago (2016-10-07 03:03:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 03:10:42 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 03:13:33 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e9bc4e0245c9a1e570ed2cf8e12152b9122275f2
Cr-Commit-Position: refs/heads/master@{#423791}

Powered by Google App Engine
This is Rietveld 408576698