Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2393083005: Moves Shell::CreateShelf() to WmShell (Closed)

Created:
4 years, 2 months ago by sky
Modified:
4 years, 2 months ago
Reviewers:
msw
CC:
chromium-reviews, alemate+watch_chromium.org, sadrul, achuith+watch_chromium.org, oshima+watch_chromium.org, kalyank, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves Shell::CreateShelf() to WmShell Same for RootWindowController and WmRootWindowController. I want to move TestSessionStateDelegate to ash/common, and it uses these. BUG=none TEST=covered by tests R=msw@chromium.org Committed: https://crrev.com/d52346b0ed3ee9c37459c4891ee7841d41547f9f Cr-Commit-Position: refs/heads/master@{#423866}

Patch Set 1 #

Patch Set 2 : tweak #

Total comments: 1

Patch Set 3 : merge #

Patch Set 4 : fix shell #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -47 lines) Patch
M ash/common/wm_root_window_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/common/wm_root_window_controller.cc View 2 chunks +23 lines, -0 lines 0 comments Download
M ash/common/wm_shell.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ash/common/wm_shell.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M ash/root_window_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/root_window_controller.cc View 2 chunks +1 line, -25 lines 0 comments Download
M ash/shell.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/shell.cc View 2 chunks +1 line, -13 lines 0 comments Download
M ash/shell/content/client/shell_browser_main_parts.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M ash/test/test_session_state_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
sky
4 years, 2 months ago (2016-10-07 00:04:59 UTC) #1
msw
lgtm with updated cl title/desc (you had me confused!) https://codereview.chromium.org/2393083005/diff/20001/ash/common/wm_root_window_controller.h File ash/common/wm_root_window_controller.h (right): https://codereview.chromium.org/2393083005/diff/20001/ash/common/wm_root_window_controller.h#newcode98 ash/common/wm_root_window_controller.h:98: ...
4 years, 2 months ago (2016-10-07 01:11:32 UTC) #2
sky
On 2016/10/07 01:11:32, msw wrote: > lgtm with updated cl title/desc (you had me confused!) ...
4 years, 2 months ago (2016-10-07 03:15:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393083005/40001
4 years, 2 months ago (2016-10-07 03:16:31 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/311968)
4 years, 2 months ago (2016-10-07 03:24:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393083005/60001
4 years, 2 months ago (2016-10-07 15:16:03 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-07 15:44:17 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 15:47:12 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d52346b0ed3ee9c37459c4891ee7841d41547f9f
Cr-Commit-Position: refs/heads/master@{#423866}

Powered by Google App Engine
This is Rietveld 408576698