Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2401683002: Removes WeakNSObject in ARC files in ios/web. (Closed)

Created:
4 years, 2 months ago by stkhapugin
Modified:
4 years, 2 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes WeakNSObject in ARC files in ios/web. Removes all WeakNSObjects in already converted implementation files. BUG=None TEST=None Committed: https://crrev.com/fe5914ac26a8132c1588fb62ffe4bcde7bd29045 Cr-Commit-Position: refs/heads/master@{#423824}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -16 lines) Patch
M ios/web/net/crw_ssl_status_updater.mm View 5 chunks +4 lines, -14 lines 0 comments Download
M ios/web/web_state/crw_pass_kit_downloader.mm View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
stkhapugin
PTAL
4 years, 2 months ago (2016-10-06 16:38:28 UTC) #2
sdefresne
lgtm
4 years, 2 months ago (2016-10-06 16:46:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401683002/1
4 years, 2 months ago (2016-10-07 09:27:02 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 09:32:14 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 09:34:18 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe5914ac26a8132c1588fb62ffe4bcde7bd29045
Cr-Commit-Position: refs/heads/master@{#423824}

Powered by Google App Engine
This is Rietveld 408576698