[heap] Concurrent slot filtering in sweeper threads.

[heap] Concurrent slot filtering in sweeper threads.

This is an intermediate step for concurrent slot filtering. This CL already makes filtering concurrent, but does not integrate it in the actual sweeping. This will be done in two follow up CLs. One for the regular slot set and one for the typed slot set.

BUG=chromium:648568
Committed: https://crrev.com/1f89d369fc952a2826f9f62901fb84fcf30920d7
Cr-Commit-Position: refs/heads/master@{#40040}

[Hannes Payer (out of office), 2016-10-06 11:33:05]

The CQ bit was checked by hpayer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 11:33:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hannes Payer (out of office), 2016-10-06 11:34:16]

The CQ bit was unchecked by hpayer@chromium.org

[Hannes Payer (out of office), 2016-10-06 12:01:07]

The CQ bit was checked by hpayer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 12:01:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hannes Payer (out of office), 2016-10-06 12:04:18]

Description was changed from

==========
[heap] Concurrent slot filtering in sweeper threads.

BUG=chromium:648568
==========

to

==========
[heap] Concurrent slot filtering in sweeper threads.

This is an intermediate step for concurrent slot filtering. This CL already
makes filtering concurrent, but does not integrate it in the actual sweeping.
This will be done in two follow up CLs. One for the regular slot set and one for
the typed slot set.

BUG=chromium:648568
==========

[Hannes Payer (out of office), 2016-10-06 12:04:18]

hpayer@chromium.org changed reviewers:
+ ulan@chromium.org

[Hannes Payer (out of office), 2016-10-06 12:15:52]

hpayer@chromium.org changed reviewers:
+ mlippautz@chromium.org

[commit-bot: I haz the power, 2016-10-06 12:29:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 12:29:52]

Dry run: This issue passed the CQ dry run.

[ulan, 2016-10-06 12:52:13]

lgtm with comments

https://codereview.chromium.org/2401563002/diff/20001/src/heap/remembered-set.cc
File src/heap/remembered-set.cc (right):

https://codereview.chromium.org/2401563002/diff/20001/src/heap/remembered-set...
src/heap/remembered-set.cc:23: if (identity == OLD_SPACE) {
Both old and map space should clear untyped slots.

https://codereview.chromium.org/2401563002/diff/20001/src/heap/remembered-set...
src/heap/remembered-set.cc:33: } else if (identity == MAP_SPACE) {
This branch is not needed.

[Michael Lippautz, 2016-10-06 13:02:20]

LGTM

https://codereview.chromium.org/2401563002/diff/20001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/2401563002/diff/20001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:3808:
RememberedSet<OLD_TO_NEW>::ClearInvalidSlots(heap_, page);
Not change in this CL, but you could simplify the branching here :)

https://codereview.chromium.org/2401563002/diff/20001/src/heap/remembered-set.cc
File src/heap/remembered-set.cc (right):

https://codereview.chromium.org/2401563002/diff/20001/src/heap/remembered-set...
src/heap/remembered-set.cc:33: } else if (identity == MAP_SPACE) {
On 2016/10/06 12:52:13, ulan wrote:
> This branch is not needed.

and the top branch should also apply for map space.

[Hannes Payer (out of office), 2016-10-06 13:22:40]

https://codereview.chromium.org/2401563002/diff/20001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/2401563002/diff/20001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:3808:
RememberedSet<OLD_TO_NEW>::ClearInvalidSlots(heap_, page);
On 2016/10/06 13:02:19, Michael Lippautz wrote:
> Not change in this CL, but you could simplify the branching here :)

Done.

https://codereview.chromium.org/2401563002/diff/20001/src/heap/remembered-set.cc
File src/heap/remembered-set.cc (right):

https://codereview.chromium.org/2401563002/diff/20001/src/heap/remembered-set...
src/heap/remembered-set.cc:23: if (identity == OLD_SPACE) {
On 2016/10/06 12:52:13, ulan wrote:
> Both old and map space should clear untyped slots.

Done.

https://codereview.chromium.org/2401563002/diff/20001/src/heap/remembered-set...
src/heap/remembered-set.cc:33: } else if (identity == MAP_SPACE) {
On 2016/10/06 13:02:19, Michael Lippautz wrote:
> On 2016/10/06 12:52:13, ulan wrote:
> > This branch is not needed.
> 
> and the top branch should also apply for map space.

Done.

[Hannes Payer (out of office), 2016-10-06 13:22:45]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2016-10-06 13:22:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org, ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/2401563002/#ps40001
(title: "comments")

[commit-bot: I haz the power, 2016-10-06 13:22:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 13:31:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 13:31:57]

Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Hannes Payer (out of office), 2016-10-06 13:33:55]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2016-10-06 13:33:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org, ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/2401563002/#ps60001
(title: "remove identity")

[commit-bot: I haz the power, 2016-10-06 13:34:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 13:59:42]

Description was changed from

==========
[heap] Concurrent slot filtering in sweeper threads.

This is an intermediate step for concurrent slot filtering. This CL already
makes filtering concurrent, but does not integrate it in the actual sweeping.
This will be done in two follow up CLs. One for the regular slot set and one for
the typed slot set.

BUG=chromium:648568
==========

to

==========
[heap] Concurrent slot filtering in sweeper threads.

This is an intermediate step for concurrent slot filtering. This CL already
makes filtering concurrent, but does not integrate it in the actual sweeping.
This will be done in two follow up CLs. One for the regular slot set and one for
the typed slot set.

BUG=chromium:648568
==========

[commit-bot: I haz the power, 2016-10-06 13:59:43]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-06 14:00:01]

Description was changed from

==========
[heap] Concurrent slot filtering in sweeper threads.

This is an intermediate step for concurrent slot filtering. This CL already
makes filtering concurrent, but does not integrate it in the actual sweeping.
This will be done in two follow up CLs. One for the regular slot set and one for
the typed slot set.

BUG=chromium:648568
==========

to

==========
[heap] Concurrent slot filtering in sweeper threads.

This is an intermediate step for concurrent slot filtering. This CL already
makes filtering concurrent, but does not integrate it in the actual sweeping.
This will be done in two follow up CLs. One for the regular slot set and one for
the typed slot set.

BUG=chromium:648568

Committed: https://crrev.com/1f89d369fc952a2826f9f62901fb84fcf30920d7
Cr-Commit-Position: refs/heads/master@{#40040}
==========

[commit-bot: I haz the power, 2016-10-06 14:00:02]

Patchset 4 (id:??) landed as
https://crrev.com/1f89d369fc952a2826f9f62901fb84fcf30920d7
Cr-Commit-Position: refs/heads/master@{#40040}

[Hannes Payer (out of office), 2016-10-06 14:20:26]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2399003002/ by hpayer@chromium.org.

The reason for reverting is: Crashing..