Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2401523002: Replace ASSERT family with DCHECK and so on in core/dom/. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Document.cpp
diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp
index 16a44a6040ba397b1284e4daafc609497024987e..adfb661b8196faf2677ef9efd8615914b352df66 100644
--- a/third_party/WebKit/Source/core/dom/Document.cpp
+++ b/third_party/WebKit/Source/core/dom/Document.cpp
@@ -975,7 +975,7 @@ Node* Document::importNode(Node* importedNode,
return nullptr;
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return nullptr;
}
@@ -1093,7 +1093,7 @@ String Document::readyState() const {
return complete;
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return String();
}
@@ -2011,7 +2011,7 @@ void Document::updateStyleAndLayout() {
FrameView* frameView = view();
if (frameView && frameView->isInPerformLayout()) {
// View layout should not be re-entrant.
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return;
}
@@ -2170,7 +2170,7 @@ void Document::pageSizeAndMarginsInPixels(int pageIndex,
break;
}
default:
- ASSERT_NOT_REACHED();
+ NOTREACHED();
}
pageSize = DoubleSize(width, height);
@@ -2967,7 +2967,7 @@ Document::PageDismissalType Document::pageDismissalEventBeingDispatched()
case UnloadEventHandled:
return NoDismissal;
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return NoDismissal;
}
@@ -5179,7 +5179,7 @@ Vector<IconURL> Document::iconURLs(int iconTypesMask) {
secondaryIcons.append(firstTouchPrecomposedIcon);
firstTouchPrecomposedIcon = newURL;
} else {
- ASSERT_NOT_REACHED();
+ NOTREACHED();
}
}
@@ -6087,7 +6087,7 @@ void Document::didAssociateFormControl(Element* element) {
}
void Document::didAssociateFormControlsTimerFired(TimerBase* timer) {
- ASSERT_UNUSED(timer, timer == &m_didAssociateFormControlsTimer);
+ DCHECK_EQ(timer, &m_didAssociateFormControlsTimer);
if (!frame() || !frame()->page())
return;
« no previous file with comments | « third_party/WebKit/Source/core/dom/DOMURLUtils.cpp ('k') | third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698