third_party/WebKit/Source/core/dom/DOMURL.cpp - Issue 2401523002: Replace ASSERT family with DCHECK and so on in core/dom/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/DOMURL.cpp

Issue 2401523002: Replace ASSERT family with DCHECK and so on in core/dom/. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/DOMURL.cpp

diff --git a/third_party/WebKit/Source/core/dom/DOMURL.cpp b/third_party/WebKit/Source/core/dom/DOMURL.cpp

index 5f54ef8bd3e814348a018971937a4acaf13eac23..dbebfe6c9fcad3d8a808a2c7995e04f4b53add6f 100644

--- a/third_party/WebKit/Source/core/dom/DOMURL.cpp

+++ b/third_party/WebKit/Source/core/dom/DOMURL.cpp

@@ -107,7 +107,9 @@ void DOMURL::updateSearchParams(const String& queryString) {

return;

AutoReset<bool> scope(&m_isInUpdate, true);

- ASSERT(m_searchParams->urlObject() == this);

+#if DCHECK_IS_ON()

+ DCHECK_EQ(m_searchParams->urlObject(), this);

+#endif

m_searchParams->setInput(queryString);

}