[ash-md] Erases the pre-MD code path for Overview Mode

[ash-md] Erases the pre-MD code path for Overview Mode

This CL should not introduce any change in behavior. The code should now
look and behave as if the Overview Mode has originally been implemented
with the Material Design look and feel.

BUG=604767, 614453
TEST=WindowSelectorTest

Committed: https://crrev.com/a606f77392bdae81e385d38b171457748a467b56
Cr-Commit-Position: refs/heads/master@{#423723}

[varkha, 2016-10-05 21:40:16]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 21:41:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2016-10-05 21:57:30]

Patchset #1 (id:1) has been deleted

[varkha, 2016-10-05 21:57:35]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 21:58:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 22:22:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 22:22:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[varkha, 2016-10-05 22:30:21]

Patchset #1 (id:20001) has been deleted

[varkha, 2016-10-05 22:33:32]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 22:34:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2016-10-05 22:38:31]

varkha@chromium.org changed reviewers:
+ tdanderson@chromium.org

[varkha, 2016-10-05 22:38:31]

PTAL - this is erasing code so should be fun to look at. Thanks!

[commit-bot: I haz the power, 2016-10-05 23:50:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 23:50:48]

Dry run: This issue passed the CQ dry run.

[tdanderson, 2016-10-06 14:31:59]

Nice! lgtm

https://chromiumcodereview.appspot.com/2401473002/diff/40001/ash/common/ash_s...
File ash/common/ash_switches.h (right):

https://chromiumcodereview.appspot.com/2401473002/diff/40001/ash/common/ash_s...
ash/common/ash_switches.h:2: // Use of this source code is governed by a
BSD-style license that can be
Please also include BUG=614453 in the CL description.

https://chromiumcodereview.appspot.com/2401473002/diff/40001/ash/common/wm/ov...
File ash/common/wm/overview/scoped_transform_overview_window.cc (left):

https://chromiumcodereview.appspot.com/2401473002/diff/40001/ash/common/wm/ov...
ash/common/wm/overview/scoped_transform_overview_window.cc:358: // With Material
Design the preview title is shown above the preview window.
nit: consider still including the first sentence "The preview title is shown
above the preview window."

https://chromiumcodereview.appspot.com/2401473002/diff/40001/ash/common/wm/ov...
File ash/common/wm/overview/scoped_transform_overview_window.cc (right):

https://chromiumcodereview.appspot.com/2401473002/diff/40001/ash/common/wm/ov...
ash/common/wm/overview/scoped_transform_overview_window.cc:379: if (&transform
!= &original_transform_) {
nit: can combine conditions on line 379 and 380

https://chromiumcodereview.appspot.com/2401473002/diff/40001/ash/common/wm/ov...
File ash/common/wm/overview/window_selector_item.cc (left):

https://chromiumcodereview.appspot.com/2401473002/diff/40001/ash/common/wm/ov...
ash/common/wm/overview/window_selector_item.cc:155: ui::ResourceBundle& rb =
ui::ResourceBundle::GetSharedInstance();
Can you remove the #include for resource_bundle.h?

[varkha, 2016-10-06 14:49:18]

Description was changed from

==========
[ash-md] Erases the pre-MD code path for Overview Mode

This CL should not introduce any change in behavior. The code should now
look and behave as if the Overview Mode has originally been implemented
with the Material Design look and feel.

BUG=604767
TEST=WindowSelectorTest
==========

to

==========
[ash-md] Erases the pre-MD code path for Overview Mode

This CL should not introduce any change in behavior. The code should now
look and behave as if the Overview Mode has originally been implemented
with the Material Design look and feel.

BUG=604767, 614453
TEST=WindowSelectorTest
==========

[varkha1, 2016-10-06 15:07:59]

varkha@google.com changed reviewers:
+ asvitkine@chromium.org, rkaplow@chromium.org, sky@chromium.org,
varkha@google.com

[varkha1, 2016-10-06 15:08:00]

+sky@ for OWNERS in ash/
+asvitkine@ or rkaplow@ for OWNERS in tools/metrics/histograms/histograms.xml

Thanks!

https://chromiumcodereview.appspot.com/2401473002/diff/40001/ash/common/ash_s...
File ash/common/ash_switches.h (right):

https://chromiumcodereview.appspot.com/2401473002/diff/40001/ash/common/ash_s...
ash/common/ash_switches.h:2: // Use of this source code is governed by a
BSD-style license that can be
On 2016/10/06 14:31:59, tdanderson wrote:
> Please also include BUG=614453 in the CL description.

Thanks!

https://chromiumcodereview.appspot.com/2401473002/diff/40001/ash/common/wm/ov...
File ash/common/wm/overview/scoped_transform_overview_window.cc (left):

https://chromiumcodereview.appspot.com/2401473002/diff/40001/ash/common/wm/ov...
ash/common/wm/overview/scoped_transform_overview_window.cc:358: // With Material
Design the preview title is shown above the preview window.
On 2016/10/06 14:31:59, tdanderson wrote:
> nit: consider still including the first sentence "The preview title is shown
> above the preview window."

Done.

https://chromiumcodereview.appspot.com/2401473002/diff/40001/ash/common/wm/ov...
File ash/common/wm/overview/scoped_transform_overview_window.cc (right):

https://chromiumcodereview.appspot.com/2401473002/diff/40001/ash/common/wm/ov...
ash/common/wm/overview/scoped_transform_overview_window.cc:379: if (&transform
!= &original_transform_) {
On 2016/10/06 14:31:59, tdanderson wrote:
> nit: can combine conditions on line 379 and 380

Done.

https://chromiumcodereview.appspot.com/2401473002/diff/40001/ash/common/wm/ov...
File ash/common/wm/overview/window_selector_item.cc (left):

https://chromiumcodereview.appspot.com/2401473002/diff/40001/ash/common/wm/ov...
ash/common/wm/overview/window_selector_item.cc:155: ui::ResourceBundle& rb =
ui::ResourceBundle::GetSharedInstance();
On 2016/10/06 14:31:59, tdanderson wrote:
> Can you remove the #include for resource_bundle.h?

No. It is still used (line 649 and line 651).

[rkaplow, 2016-10-06 15:13:05]

lgtm

[varkha, 2016-10-06 15:14:45]

varkha@chromium.org changed reviewers:
- asvitkine@chromium.org, varkha@google.com

[varkha, 2016-10-06 17:24:55]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 17:25:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 19:33:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 19:33:03]

Dry run: This issue passed the CQ dry run.

[sky, 2016-10-06 21:08:31]

LGTM

[varkha, 2016-10-06 23:09:09]

The CQ bit was checked by varkha@chromium.org

[varkha, 2016-10-06 23:09:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2401473002/#ps60001
(title: "[ash-md] Erases the pre-MD code path for Overview Mode (comments)")

[commit-bot: I haz the power, 2016-10-06 23:10:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 23:16:50]

Description was changed from

==========
[ash-md] Erases the pre-MD code path for Overview Mode

This CL should not introduce any change in behavior. The code should now
look and behave as if the Overview Mode has originally been implemented
with the Material Design look and feel.

BUG=604767, 614453
TEST=WindowSelectorTest
==========

to

==========
[ash-md] Erases the pre-MD code path for Overview Mode

This CL should not introduce any change in behavior. The code should now
look and behave as if the Overview Mode has originally been implemented
with the Material Design look and feel.

BUG=604767, 614453
TEST=WindowSelectorTest
==========

[commit-bot: I haz the power, 2016-10-06 23:16:51]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-10-06 23:19:54]

Description was changed from

==========
[ash-md] Erases the pre-MD code path for Overview Mode

This CL should not introduce any change in behavior. The code should now
look and behave as if the Overview Mode has originally been implemented
with the Material Design look and feel.

BUG=604767, 614453
TEST=WindowSelectorTest
==========

to

==========
[ash-md] Erases the pre-MD code path for Overview Mode

This CL should not introduce any change in behavior. The code should now
look and behave as if the Overview Mode has originally been implemented
with the Material Design look and feel.

BUG=604767, 614453
TEST=WindowSelectorTest

Committed: https://crrev.com/a606f77392bdae81e385d38b171457748a467b56
Cr-Commit-Position: refs/heads/master@{#423723}
==========

[commit-bot: I haz the power, 2016-10-06 23:19:55]

Patchset 2 (id:??) landed as
https://crrev.com/a606f77392bdae81e385d38b171457748a467b56
Cr-Commit-Position: refs/heads/master@{#423723}