Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: components/cronet/android/test/native_test_server.cc

Issue 2401413002: Fix testGetResponseAfterWriteFailed flake (Closed)
Patch Set: self review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/test/native_test_server.cc
diff --git a/components/cronet/android/test/native_test_server.cc b/components/cronet/android/test/native_test_server.cc
index bf47af3b7dff22f83cb76725e48cbee69de91ff0..46d521c4027983f0a68035792e305caabfd3e4c9 100644
--- a/components/cronet/android/test/native_test_server.cc
+++ b/components/cronet/android/test/native_test_server.cc
@@ -234,6 +234,7 @@ void ShutdownNativeTestServer(JNIEnv* env,
const JavaParamRef<jclass>& jcaller) {
if (!g_test_server)
return;
+ CHECK(g_test_server->ShutdownAndWaitUntilComplete());
delete g_test_server;
pauljensen 2016/10/10 12:56:21 Doesn't this line already do this? https://cs.chro
xunjieli 2016/10/10 13:04:44 ah, that's a good point. I forgot about it :(
g_test_server = NULL;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698