Fix testGetResponseAfterWriteFailed flake

components/cronet/android/test/native_test_server.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/cronet/android/test/native_test_server.h"
 
 #include <memory>
 #include <string>
 #include <utility>
 
@@ skipping 216 matching lines @@
   // Add a third handler for paths that NativeTestServerRequestHandler does not
   // handle.
   g_test_server->ServeFilesFromDirectory(test_files_root);
   return g_test_server->Start();
 }
 
 void ShutdownNativeTestServer(JNIEnv* env,
                               const JavaParamRef<jclass>& jcaller) {
   if (!g_test_server)
     return;
+  CHECK(g_test_server->ShutdownAndWaitUntilComplete());
   delete g_test_server;

[pauljensen, 2016/10/10 12:56:21]

Doesn't this line already do this?
https://cs.chromium.org/chromium/src/net/test/embedded_test_server/embedded_t...

[xunjieli, 2016/10/10 13:04:44]

ah, that's a good point. I forgot about it :(

   g_test_server = NULL;
 }
 
 ScopedJavaLocalRef<jstring> GetEchoBodyURL(
     JNIEnv* env,
     const JavaParamRef<jclass>& jcaller) {
   DCHECK(g_test_server);
   GURL url = g_test_server->GetURL(kEchoBodyPath);
   return base::android::ConvertUTF8ToJavaString(env, url.spec());
 }
@@ skipping 73 matching lines @@
 #else
   return JNI_FALSE;
 #endif
 }
 
 bool RegisterNativeTestServer(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace cronet