chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc - Issue 2401393003: Add multiline braille support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc

Issue 2401393003: Add multiline braille support. (Closed)

Patch Set: more tests Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc ('k') | chrome/browser/extensions/api/braille_display_private/braille_display_private_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc

diff --git a/chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc b/chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc

index 73d1bdbf342f3c0dda2292decc6ccfcd115fa5e5..efa0629297fdc357524251ec49e0942d17624b92 100644

--- a/chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc

+++ b/chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc

@@ -169,11 +169,15 @@ BrailleDisplayPrivateWriteDotsFunction::

bool BrailleDisplayPrivateWriteDotsFunction::Prepare() {

params_ = WriteDots::Params::Create(*args_);

EXTENSION_FUNCTION_VALIDATE(params_);

+ EXTENSION_FUNCTION_VALIDATE(

+ params_->cells.size() >=

+ static_cast<size_t>(params_->columns * params_->rows));

return true;

}

void BrailleDisplayPrivateWriteDotsFunction::Work() {

- BrailleController::GetInstance()->WriteDots(params_->cells);

+ BrailleController::GetInstance()->WriteDots(params_->cells, params_->columns,

+ params_->rows);

}

bool BrailleDisplayPrivateWriteDotsFunction::Respond() {