Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Side by Side Diff: chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc

Issue 2401393003: Add multiline braille support. (Closed)
Patch Set: more tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/braille_display_private/braille_display_ private_api.h" 5 #include "chrome/browser/extensions/api/braille_display_private/braille_display_ private_api.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/lazy_instance.h" 9 #include "base/lazy_instance.h"
10 #include "build/build_config.h" 10 #include "build/build_config.h"
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 BrailleDisplayPrivateWriteDotsFunction() { 162 BrailleDisplayPrivateWriteDotsFunction() {
163 } 163 }
164 164
165 BrailleDisplayPrivateWriteDotsFunction:: 165 BrailleDisplayPrivateWriteDotsFunction::
166 ~BrailleDisplayPrivateWriteDotsFunction() { 166 ~BrailleDisplayPrivateWriteDotsFunction() {
167 } 167 }
168 168
169 bool BrailleDisplayPrivateWriteDotsFunction::Prepare() { 169 bool BrailleDisplayPrivateWriteDotsFunction::Prepare() {
170 params_ = WriteDots::Params::Create(*args_); 170 params_ = WriteDots::Params::Create(*args_);
171 EXTENSION_FUNCTION_VALIDATE(params_); 171 EXTENSION_FUNCTION_VALIDATE(params_);
172 EXTENSION_FUNCTION_VALIDATE(
173 params_->cells.size() >=
174 static_cast<size_t>(params_->columns * params_->rows));
172 return true; 175 return true;
173 } 176 }
174 177
175 void BrailleDisplayPrivateWriteDotsFunction::Work() { 178 void BrailleDisplayPrivateWriteDotsFunction::Work() {
176 BrailleController::GetInstance()->WriteDots(params_->cells); 179 BrailleController::GetInstance()->WriteDots(params_->cells, params_->columns,
180 params_->rows);
177 } 181 }
178 182
179 bool BrailleDisplayPrivateWriteDotsFunction::Respond() { 183 bool BrailleDisplayPrivateWriteDotsFunction::Respond() {
180 return true; 184 return true;
181 } 185 }
182 } // namespace api 186 } // namespace api
183 } // namespace extensions 187 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698