Remove sundry IsModeMaterial checks.

Remove sundry IsModeMaterial checks.

BUG=648281
TBR=sadrul@chromium.org

Committed: https://crrev.com/944999ffef37ec77f33ff07cffd44fe363fc6662
Cr-Commit-Position: refs/heads/master@{#424633}

[Evan Stade, 2016-10-11 00:51:24]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 00:51:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 01:06:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 01:06:06]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Evan Stade, 2016-10-11 16:54:04]

estade@chromium.org changed reviewers:
+ pkasting@chromium.org, varkha@chromium.org

[Evan Stade, 2016-10-11 16:54:08]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 16:54:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2016-10-11 16:55:22]

Description was changed from

==========
Remove sundry IsModeMaterial checks.

WIP

BUG=
==========

to

==========
Remove sundry IsModeMaterial checks.

BUG=648281
==========

[commit-bot: I haz the power, 2016-10-11 17:33:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 17:33:26]

Dry run: This issue passed the CQ dry run.

[Peter Kasting, 2016-10-11 22:49:19]

LGTM

https://codereview.chromium.org/2401363005/diff/40001/chrome/browser/ui/exten...
File chrome/browser/ui/extensions/icon_with_badge_image_source.cc (left):

https://codereview.chromium.org/2401363005/diff/40001/chrome/browser/ui/exten...
chrome/browser/ui/extensions/icon_with_badge_image_source.cc:18: #include
"third_party/skia/include/core/SkTypeface.h"
Looks like this #include can disappear too?  Please look for any other dead
#includes in this and other files.

https://codereview.chromium.org/2401363005/diff/40001/chrome/browser/ui/exten...
File chrome/browser/ui/extensions/icon_with_badge_image_source.cc (right):

https://codereview.chromium.org/2401363005/diff/40001/chrome/browser/ui/exten...
chrome/browser/ui/extensions/icon_with_badge_image_source.cc:115: //
http://crbug.com/619499
Nit: I'd move this comment above the whole statement; it's effectively what the
whole statement is accomplishing, and I think it's easier to read code when it
doesn't have comments mid-statement.

https://codereview.chromium.org/2401363005/diff/40001/chrome/browser/ui/exten...
chrome/browser/ui/extensions/icon_with_badge_image_source.cc:139:
std::min(kMaxTextWidth, canvas->GetStringWidth(utf16_text, base_font));
Nit: Should this still have a blank line after?

https://codereview.chromium.org/2401363005/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/tabs/tab_strip_unittest.cc (right):

https://codereview.chromium.org/2401363005/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/tabs/tab_strip_unittest.cc:332: //
TODO(varkha,pkasting): Update the test for Material Design layout.
Just set the TODO to me alone.

[Evan Stade, 2016-10-12 00:12:52]

Description was changed from

==========
Remove sundry IsModeMaterial checks.

BUG=648281
==========

to

==========
Remove sundry IsModeMaterial checks.

BUG=648281
TBR=sadrul@chromium.org
==========

[Evan Stade, 2016-10-12 00:12:53]

estade@chromium.org changed reviewers:
+ sadrul@chromium.org

[Evan Stade, 2016-10-12 00:13:07]

TBR'ing sadrul for deletions in 	ui/views/linux_ui/linux_ui.h

https://codereview.chromium.org/2401363005/diff/40001/chrome/browser/ui/exten...
File chrome/browser/ui/extensions/icon_with_badge_image_source.cc (left):

https://codereview.chromium.org/2401363005/diff/40001/chrome/browser/ui/exten...
chrome/browser/ui/extensions/icon_with_badge_image_source.cc:18: #include
"third_party/skia/include/core/SkTypeface.h"
On 2016/10/11 22:49:18, Peter Kasting (very slow) wrote:
> Looks like this #include can disappear too?  Please look for any other dead
> #includes in this and other files.

Done.

https://codereview.chromium.org/2401363005/diff/40001/chrome/browser/ui/exten...
File chrome/browser/ui/extensions/icon_with_badge_image_source.cc (right):

https://codereview.chromium.org/2401363005/diff/40001/chrome/browser/ui/exten...
chrome/browser/ui/extensions/icon_with_badge_image_source.cc:115: //
http://crbug.com/619499
On 2016/10/11 22:49:18, Peter Kasting (very slow) wrote:
> Nit: I'd move this comment above the whole statement; it's effectively what
the
> whole statement is accomplishing, and I think it's easier to read code when it
> doesn't have comments mid-statement.

Done.

https://codereview.chromium.org/2401363005/diff/40001/chrome/browser/ui/exten...
chrome/browser/ui/extensions/icon_with_badge_image_source.cc:139:
std::min(kMaxTextWidth, canvas->GetStringWidth(utf16_text, base_font));
On 2016/10/11 22:49:18, Peter Kasting (very slow) wrote:
> Nit: Should this still have a blank line after?

I dunno, seems fine this way? In my view of the world the blank line was only
there because of the closing curly brace (I for one like blank lines after
scoped blocks like that).

https://codereview.chromium.org/2401363005/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/tabs/tab_strip_unittest.cc (right):

https://codereview.chromium.org/2401363005/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/tabs/tab_strip_unittest.cc:332: //
TODO(varkha,pkasting): Update the test for Material Design layout.
On 2016/10/11 22:49:18, Peter Kasting (very slow) wrote:
> Just set the TODO to me alone.

Done.

[Evan Stade, 2016-10-12 00:13:12]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-10-12 00:13:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2401363005/#ps60001
(title: "pkasting review and remove includes")

[commit-bot: I haz the power, 2016-10-12 00:13:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-10-12 00:15:37]

cool lgtm

[commit-bot: I haz the power, 2016-10-12 00:17:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 00:17:09]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Evan Stade, 2016-10-12 00:39:31]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-10-12 00:39:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org, sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2401363005/#ps80001
(title: "resolve merge conflict")

[commit-bot: I haz the power, 2016-10-12 00:40:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 01:22:49]

Description was changed from

==========
Remove sundry IsModeMaterial checks.

BUG=648281
TBR=sadrul@chromium.org
==========

to

==========
Remove sundry IsModeMaterial checks.

BUG=648281
TBR=sadrul@chromium.org
==========

[commit-bot: I haz the power, 2016-10-12 01:22:52]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-12 01:25:51]

Description was changed from

==========
Remove sundry IsModeMaterial checks.

BUG=648281
TBR=sadrul@chromium.org
==========

to

==========
Remove sundry IsModeMaterial checks.

BUG=648281
TBR=sadrul@chromium.org

Committed: https://crrev.com/944999ffef37ec77f33ff07cffd44fe363fc6662
Cr-Commit-Position: refs/heads/master@{#424633}
==========

[commit-bot: I haz the power, 2016-10-12 01:25:53]

Patchset 5 (id:??) landed as
https://crrev.com/944999ffef37ec77f33ff07cffd44fe363fc6662
Cr-Commit-Position: refs/heads/master@{#424633}